Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1608
@cburlinchon, per my email to the dev list earlier this week, I plan on
doing a release soon so if you want this in there please update the PR ASAP.
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1610
---
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1610
ARTEMIS-1477 Add classifiers to the native transports
The changes to remove netty all removes the classifiers that add the
dependency to the netty transport that includes the
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1609
Thanks!
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1609
---
GitHub user shailendra14k opened a pull request:
https://github.com/apache/activemq-artemis/pull/1609
[ARTEMIS-1480]Console purge Queue is broken
https://issues.apache.org/jira/browse/ARTEMIS-1480
You can merge this pull request into a Git repository by running:
$ git pull
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146671299
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java
---
@@ -54,92 +172,94 @@
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1534
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146663570
--- Diff:
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1607
Vertx and aerogear were removed for lack of users also. No one complained.
If we had complainers we could put them back.
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146628048
--- Diff:
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146624344
--- Diff:
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146623554
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java
---
@@ -54,92 +172,94 @@ public static
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146623227
--- Diff:
Github user cburlinchon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1608
Hi,
When sending large message I've hit this:
java.lang.IllegalArgumentException: Missing validated user from the Artemis
message
Seems we don't setValidatedUserID
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146618435
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java
---
@@ -54,92 +172,94 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146618187
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java
---
@@ -54,92 +172,94 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146618064
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java
---
@@ -54,92 +172,94 @@
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1605
@franz1981, this makes sense and good to know +1, ill leave some comments
in place in code in a sec, where looks like some bits still leaked into
existing logic. and let you
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1605
@michaelandrepearce
> To mitigate this concern, have we an ability to validate the result is
the same before and after this change? e.g. some sort of test?
Right now
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1608
There doesn't seem to be a JIRA issue associated with this, nor are there
tests, or even text explaining why the change is needed. Would be good to add
those.
---
GitHub user cburlinchon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1608
Set validated user in all messages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cburlinchon/activemq-artemis master
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1605
@franz1981 i really like the ability to get a histogram of the sync test so
you can see the percentiles of the disk performance from activemq's view. I do
share some concerns
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1607
there wasn't a JIRA to remove them, they just didn't get handled in the
move to 2.x, and no ones done the work to update them to re-add them. Its not
that we don't want
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1607
@michaelandrepearce apart from the fact that those are all removed now?
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1607
@gemmellr have removed entirely to avoid issue.
---
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/1607
@michaelandrepearce Ah, I missed the note while skimming. The methods will
presumably be at package visibility in keeping with the fact they are not
intended to be used outside the
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1607
@gemmellr I've removed the qpid JMS bit.
@tabish121 i see this no different to the vertx connecter service etc that
was/is in 1.5.x range.
---
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1607
Given that the code being used from Qpid JMS is internal implementation
that has no promise of remaining stable and will not be made public I think
that stuff should go.
So
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1607
@gemmellr agreed on class def in names space this was because we couldn't
create object because methods are package, as it notes it would be good if
could get qpid to make them
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/1607
Skimming the code quickly, I had to do a double take on a couple of
occasions, and had some related observations.
There looked to be extensive use of implementation detail
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146586855
--- Diff:
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146586304
--- Diff:
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146586161
--- Diff:
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146579371
--- Diff:
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146578570
--- Diff:
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146578236
--- Diff:
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1605
@clebertsuconic Done!
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1605
@clebertsuconic ok!! I'm updating the PR with it!
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1605
Lets use it under free public domain. As they allow it.
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1605
@clebertsuconic I'm not a lot familar with these, but:
> For users of this code who wish to consume it under the "BSD" license
rather than under the public domain or CC0
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1605
The license says public domain. And if you need a license BSD.
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146539097
--- Diff: pom.xml ---
@@ -625,6 +626,15 @@
+
+
+
+
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146537959
--- Diff: pom.xml ---
@@ -625,6 +626,15 @@
+
+
+
+
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146537426
--- Diff: pom.xml ---
@@ -625,6 +626,15 @@
+
+
+
+
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146536958
--- Diff: pom.xml ---
@@ -625,6 +626,15 @@
+
+
+
+
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146536414
--- Diff: pom.xml ---
@@ -625,6 +626,15 @@
+
+
+
+
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146535926
--- Diff: artemis-cli/pom.xml ---
@@ -83,6 +83,10 @@
${commons.lang.version}
+
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1607#discussion_r146532318
--- Diff: docs/user-manual/en/kafka-bridges.md ---
@@ -0,0 +1,179 @@
+# Apache ActiveMQ Kafka Bridge
+
+