[GitHub] activemq-artemis pull request #1979: ARTEMIS-1776 Asynchronous Flow control ...

2018-03-28 Thread clebertsuconic
GitHub user clebertsuconic reopened a pull request: https://github.com/apache/activemq-artemis/pull/1979 ARTEMIS-1776 Asynchronous Flow control on the bridge You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #1979: ARTEMIS-1776 Asynchronous Flow control ...

2018-03-28 Thread clebertsuconic
Github user clebertsuconic closed the pull request at: https://github.com/apache/activemq-artemis/pull/1979 ---

[GitHub] activemq-artemis issue #1979: ARTEMIS-1776 Asynchronous Flow control on the ...

2018-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1979 I'm running the testuite.. will reopen later ---

[GitHub] activemq-artemis pull request #1979: ARTEMIS-1776 Asynchronous Flow control ...

2018-03-28 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1979 ARTEMIS-1776 Asynchronous Flow control on the bridge You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...

2018-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1976 if you could please review what's missing.. ---

[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...

2018-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1976 Ouch. I merged it. I will revert and push -f. ---

[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...

2018-03-28 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1976 Merged? But there was a missing commit to be cherry picked yet: https://github.com/apache/activemq-artemis/pull/1977 ---

[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...

2018-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1976 Close this please? it's been merged ---

[GitHub] activemq-artemis pull request #1977: ARTEMIS-1774 Node Manager Store table n...

2018-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1977 ---

[GitHub] activemq-artemis pull request #1978: ARTEMIS-1775: Replace wrong env variabl...

2018-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1978 ---

[GitHub] activemq-artemis pull request #1978: ARTEMIS-1775: Replace wrong env variabl...

2018-03-28 Thread graben
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/1978 ARTEMIS-1775: Replace wrong env variable ARTEMIS_ETC_INSTANCE with ARTEMIS_INSTANCE_ETC You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #1977: ARTEMIS-1774 Node Manager Store table name sho...

2018-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1977 it looks good. will wait travis CI and merge it. ---

[GitHub] activemq-artemis pull request #1977: ARTEMIS-1774 Node Manager Store table n...

2018-03-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1977#discussion_r177791184 --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/DBOption.java --- @@ -74,9 +74,12 @@

[GitHub] activemq-artemis pull request #1977: ARTEMIS-1774 Node Manager Store table n...

2018-03-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1977#discussion_r177790312 --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/DBOption.java --- @@ -74,9 +74,12 @@

[GitHub] activemq-artemis pull request #1977: ARTEMIS-1774 Node Manager Store table n...

2018-03-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1977#discussion_r177789837 --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java --- @@ -278,9 +278,12 @@ @Option(name =

[GitHub] activemq-artemis issue #1977: ARTEMIS-1774 Node Manager Store table name sho...

2018-03-28 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1977 @clebertsuconic I have added CLI `Create` and `DBOption` configuration too. The first because it was already handling the other JDBC HA configuration options, while the second one

[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...

2018-03-28 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1976 The CI tests are fine, but probably I will cherry-pick https://github.com/apache/activemq-artemis/pull/1977 too, in order to be feature complete. ---

[GitHub] activemq-artemis pull request #1977: ARTEMIS-1774 Node Manager Store table n...

2018-03-28 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1977 ARTEMIS-1774 Node Manager Store table name should be configurable It exposes the table name configuration for: - CLI command - configuration file The docs are updated