[GitHub] activemq-artemis pull request #2139: ARTEMIS-1927 treat exceptions and disco...

2018-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2139 ---

[GitHub] activemq-artemis pull request #2133: ARTEMIS-1923 fix constructing binding j...

2018-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2133 ---

[GitHub] activemq-artemis pull request #2139: ARTEMIS-1927 treat exceptions and disco...

2018-06-12 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2139#discussion_r194892207 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java --- @@ -554,20

[GitHub] activemq-artemis pull request #2139: ARTEMIS-1927 treat exceptions and disco...

2018-06-12 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2139#discussion_r194892092 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java --- @@ -554,20

[GitHub] activemq-artemis pull request #2139: ARTEMIS-1927 treat exceptions and disco...

2018-06-12 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2139#discussion_r194890149 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java --- @@ -554,20 +558,13 @@

[GitHub] activemq-artemis pull request #2139: ARTEMIS-1927 treat exceptions and disco...

2018-06-12 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2139 ARTEMIS-1927 treat exceptions and disconnect properly I couldn't do this with a test as this is dependent on windows. Regular testsuite should be sufficient as long as you run in

[GitHub] activemq-artemis pull request #2138: ARTEMIS-1926 refactor SSLContext

2018-06-12 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2138 ARTEMIS-1926 refactor SSLContext You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1926

[GitHub] activemq-artemis issue #2133: ARTEMIS-1923 fix constructing binding journali...

2018-06-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2133 I will ammend the commit with a test ---

[GitHub] activemq-artemis pull request #2137: NO-JIRA fix JMS destination cache doc

2018-06-12 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2137 NO-JIRA fix JMS destination cache doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work

[GitHub] activemq-artemis pull request #2132: ARTEMIS-1893: Treat the detach of a lin...

2018-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2132 ---

[GitHub] activemq-artemis issue #2122: ARTEMIS-1904 Jmx Management Security Tests

2018-06-12 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/2122 @mtaylor worked with Andy and figured out ARTEMIS-1916 is not valid (PR will be discarded). I've fixed the test and it should be ready for review now. ---