Re: HEADS-UP ActiveMQ Artemis 2.6.3 to be cut Friday the 10th

2018-08-28 Thread Clebert Suconic
I am working on a latest fix I should have sent by tomorrow.. Would anyone have anything else to send it? what about I cut it tomorrow afternoon (US EST time).? On Tue, Aug 14, 2018 at 12:24 PM Clebert Suconic wrote: > > Ok.. lets hold it.. and I will work on it. -- Clebert Suconic

[GitHub] activemq-artemis pull request #2277: ARTEMIS-2062 Only attempt to refill cre...

2018-08-28 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2277 ARTEMIS-2062 Only attempt to refill credit when needed Avoid firing the offerProducerCredit code when we know that the credit is low enough that a refill is needed which avoids lock

[GitHub] activemq-artemis issue #2276: [ARTEMIS-2061] reorder of recovery manager to ...

2018-08-28 Thread ochaloup
Github user ochaloup commented on the issue: https://github.com/apache/activemq-artemis/pull/2276 sorry, this was a wrong fix ---

[GitHub] activemq-artemis pull request #2276: [ARTEMIS-2061] reorder of recovery mana...

2018-08-28 Thread ochaloup
Github user ochaloup closed the pull request at: https://github.com/apache/activemq-artemis/pull/2276 ---

[GitHub] activemq-artemis pull request #2272: ARTEMIS-2057 Fix runaway credit grants

2018-08-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2272 ---

[GitHub] activemq-artemis pull request #2276: [ARTEMIS-2061] reorder of recovery mana...

2018-08-28 Thread ochaloup
GitHub user ochaloup opened a pull request: https://github.com/apache/activemq-artemis/pull/2276 [ARTEMIS-2061] reorder of recovery manager to start after broker is readt https://issues.apache.org/jira/browse/ARTEMIS-2061 The RA starts recovery manager before the broker is

[GitHub] activemq-artemis pull request #2275: ARTEMIS-2060 OpenSSL tests broken after...

2018-08-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2275 ---

[GitHub] activemq-artemis pull request #2274: ARTEMIS-2059 NettyWritable should use U...

2018-08-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2274#discussion_r213379239 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/util/NettyWritable.java --- @@

[GitHub] activemq-artemis pull request #2275: ARTEMIS-2060 OpenSSL tests broken after...

2018-08-28 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2275 ARTEMIS-2060 OpenSSL tests broken after Netty upgrade You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis issue #2272: ARTEMIS-2057 Fix runaway credit grants

2018-08-28 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2272 @gemmellr I've pushed some updates based on comments, thanks for reviewing ---

[GitHub] activemq-artemis pull request #2263: ARTEMIS-2051 add trace logging for JDBC

2018-08-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2263 ---

[GitHub] activemq-artemis pull request #2272: ARTEMIS-2057 Fix runaway credit grants

2018-08-28 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2272#discussion_r213342138 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallbackTest.java ---

[GitHub] activemq-artemis pull request #2272: ARTEMIS-2057 Fix runaway credit grants

2018-08-28 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2272#discussion_r213343201 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallbackTest.java ---

[GitHub] activemq-artemis pull request #2272: ARTEMIS-2057 Fix runaway credit grants

2018-08-28 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2272#discussion_r213342991 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallbackTest.java ---

[GitHub] activemq-artemis pull request #2272: ARTEMIS-2057 Fix runaway credit grants

2018-08-28 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2272#discussion_r213341266 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java ---

[GitHub] activemq-artemis pull request #2272: ARTEMIS-2057 Fix runaway credit grants

2018-08-28 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2272#discussion_r213343972 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallbackTest.java ---

[GitHub] activemq-artemis issue #2274: ARTEMIS-2059 NettyWritable should use UTF-8 ex...

2018-08-28 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2274 Not sure I'd call it a bug really, more that this is a memory optimisation, one that shouldnt be getting used much since it only comes into play if you are encoding things (whereas it

[GitHub] activemq-artemis issue #2274: ARTEMIS-2059 NettyWritable should use UTF-8 ex...

2018-08-28 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2274 @tabish121 @gemmellr I will be probably able to take a further look on it after wednesday... Anyway I think that this PR as it is will just fix the bug at a performance cost:

[GitHub] activemq-artemis pull request #2274: ARTEMIS-2059 NettyWritable should use U...

2018-08-28 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2274 ARTEMIS-2059 NettyWritable should use UTF-8 exact length to encode strings NettyWritable.put(String) tries to enlarge the buffer used to write a UTF-8 string until

[GitHub] activemq-artemis pull request #2273: ARTEMIS-2058 Support any kind of extraP...

2018-08-28 Thread calohmn
GitHub user calohmn opened a pull request: https://github.com/apache/activemq-artemis/pull/2273 ARTEMIS-2058 Support any kind of extraProperties in AmqpCoreConverter This fixes [ARTEMIS-2058](https://issues.apache.org/jira/browse/ARTEMIS-2058). You can merge this pull request into

[GitHub] activemq-artemis issue #2099: [ARTEMIS-1879] Warnings in log when failover i...

2018-08-28 Thread JiriOndrusek
Github user JiriOndrusek commented on the issue: https://github.com/apache/activemq-artemis/pull/2099 retest this please ---