[GitHub] activemq-artemis pull request #2305: NO-JIRA - Page.write() should throw exc...

2018-09-12 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2305#discussion_r217242750 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java --- @@ -223,7 +223,7 @@ private int

[GitHub] activemq-artemis pull request #2307: ARTEMIS-2070 broker can reduce buffer c...

2018-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2307 ---

[GitHub] activemq-artemis pull request #2310: ARTEMIS-2084: Failover will not work wi...

2018-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2310 ---

[GitHub] activemq-artemis pull request #2308: ARTEMIS-2083 Decode only the relavent p...

2018-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2308 ---

[GitHub] activemq-artemis pull request #2310: ARTEMIS-2084: Failover will not work wi...

2018-09-12 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2310 ARTEMIS-2084: Failover will not work with cable disconnect You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #2293: ARTEMIS-2075 - allow Extra backups to try to r...

2018-09-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2293 @andytaylor I have added a few questions to the JIRA, as the question is about the JIRA and not the PR itself. ---

[GitHub] activemq-artemis pull request #2306: ENTMQBR-1569 - make sure to send credit...

2018-09-12 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2306#discussion_r217183988 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java ---

[GitHub] activemq-artemis pull request #2309: NO-JIRA Fix condition timeouts to avoid...

2018-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2309 ---

[GitHub] activemq-artemis pull request #2309: NO-JIRA Fix condition timeouts to avoid...

2018-09-12 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2309 NO-JIRA Fix condition timeouts to avoid spurious failures The waits for expiration are set at the same value as the expiration interval default to in the test support setup so on

[GitHub] activemq-artemis pull request #2308: ARTEMIS-2083 Decode only the relavent p...

2018-09-12 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2308#discussion_r217179064 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java --- @@

[GitHub] activemq-artemis pull request #2308: ARTEMIS-2083 Decode only the relavent p...

2018-09-12 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2308#discussion_r217176110 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java --- @@

[GitHub] activemq-artemis pull request #2308: ARTEMIS-2083 Decode only the relavent p...

2018-09-12 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2308#discussion_r217175929 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java --- @@

[GitHub] activemq-artemis issue #2306: ENTMQBR-1569 - make sure to send credits on re...

2018-09-12 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2306 Seems like https://issues.apache.org/jira/browse/ARTEMIS-1898 might be relevant to one part of the changes. ---

[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...

2018-09-12 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2300 So first then ill make a pr to switch that on master and then i can send a cherrypick safely. Ill get this done tomorrow ---

[GitHub] activemq-artemis pull request #2306: ENTMQBR-1569 - make sure to send credit...

2018-09-12 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2306#discussion_r217160287 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java ---

[GitHub] activemq-artemis issue #2306: ENTMQBR-1569 - make sure to send credits on re...

2018-09-12 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2306 This should be referencing some ActiveMQ Artemis JIRA issue and not an JIRA from an external tracker. ---

[GitHub] activemq-artemis pull request #2307: ARTEMIS-2070 broker can reduce buffer c...

2018-09-12 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2307#discussion_r217143867 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java --- @@ -400,17 +398,10 @@

[GitHub] activemq-artemis pull request #2308: ARTEMIS-2083 Decode only the relavent p...

2018-09-12 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2308 ARTEMIS-2083 Decode only the relavent portions of the message Ensure that the Body of the message is never decoded in the partial decode phase of the message processing and also

[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...

2018-09-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2300 consumers before dispatch.. that's not a feature suitable for 2.6.x.. is it? that means it would be 2. If you convince everybody that consumersBeforeDispatch is

[GitHub] activemq-artemis pull request #2284: ARTEMIS-2067 Clean up some code in the ...

2018-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2284 ---

[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...

2018-09-12 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2300 @clebertsuconic there is a small issue cherrypicking this: 1) ill need to cherry pick in the consumers before dispatch change, as thats in 2.7 and these fields are

[GitHub] activemq-artemis pull request #2307: ARTEMIS-2070 broker can reduce buffer c...

2018-09-12 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2307#discussion_r217096333 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java --- @@ -400,17 +398,10 @@

[GitHub] activemq-artemis pull request #2305: NO-JIRA - Page.write() should throw exc...

2018-09-12 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2305#discussion_r217092142 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java --- @@ -223,7 +223,7 @@ private int

[GitHub] activemq-artemis pull request #2307: ARTEMIS-2070 broker can reduce buffer c...

2018-09-12 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2307 ARTEMIS-2070 broker can reduce buffer copies with large messages It includes several improvements on large messages: - AMQP and OpenWire: it reduces the number of copies of the

[GitHub] activemq-artemis pull request #2306: ENTMQBR-1569 - make sure to send credit...

2018-09-12 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/2306 ENTMQBR-1569 - make sure to send credits on rejected messages And also to run the credit runnables once memory is free in fail mode

[GitHub] activemq-artemis issue #2293: ARTEMIS-2075 - allow Extra backups to try to r...

2018-09-12 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2293 retest this please ---

[GitHub] activemq-artemis issue #2293: ARTEMIS-2075 - allow Extra backups to try to r...

2018-09-12 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2293 please retest this ---