[GitHub] activemq-artemis pull request #2348: ARTEMIS-2112 Remove JMX props from star...

2018-10-05 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2348 ARTEMIS-2112 Remove JMX props from start scripts JMX configuration is now done via management.xml. Configuring JMX via the start scripts could result in unexpected behavior since the

[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-05 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 @franz1981, thanks for the suggestion, but I don't think this is *that* kind of leak. I came up with a way to test it and updated the PR. ---

[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-05 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 You can take a weak reference of the ManagementContext instance you want to test the leak, force a GC + run finalizer (we have a method in the test suite for that) and then verify that

[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-05 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 I couldn't find a way to write a test for this so I tested manually using the `forceFailover()` management method on the `ActiveMQServerControl`. If anybody has any clever ideas I'd

[GitHub] activemq-artemis pull request #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-05 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2347 ARTEMIS-2111 ManagementContext can leak You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2111

[GitHub] activemq pull request #302: [AMQ-7067] KahaDB Recovery can experience a dang...

2018-10-05 Thread jgoodyear
GitHub user jgoodyear opened a pull request: https://github.com/apache/activemq/pull/302 [AMQ-7067] KahaDB Recovery can experience a dangling transaction when… [AMQ-7067] KahaDB Recovery can experience a dangling transaction when prepare and commit occur on different pagefiles.

[GitHub] activemq-artemis pull request #2346: ARTEMIS-2110 allow a lease renew withou...

2018-10-05 Thread gtully
Github user gtully closed the pull request at: https://github.com/apache/activemq-artemis/pull/2346 ---

[GitHub] activemq-artemis pull request #2346: ARTEMIS-2110 allow a lease renew withou...

2018-10-05 Thread gtully
GitHub user gtully reopened a pull request: https://github.com/apache/activemq-artemis/pull/2346 ARTEMIS-2110 allow a lease renew without update to the expiry timesta… …mp. Fix intermittent failure of

[GitHub] activemq-artemis issue #2346: ARTEMIS-2110 allow a lease renew without updat...

2018-10-05 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/2346 seems building the web site is the crux. it can be disabled with: mvn -Pfast-tests -Pextra-tests -B install -q -pl '!artemis-web' ---

[GitHub] activemq-artemis issue #2346: ARTEMIS-2110 allow a lease renew without updat...

2018-10-05 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/2346 The ci build failure seems may be related to the doc generation... there is no output for 10 mins and a termination after 42 mins: