[GitHub] activemq-artemis pull request #2368: Grammar and spelling fixes

2018-10-11 Thread alkaliphile
GitHub user alkaliphile opened a pull request: https://github.com/apache/activemq-artemis/pull/2368 Grammar and spelling fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/alkaliphile/activemq-artemis master Alternatively

[GitHub] activemq-artemis issue #2312: ARTEMIS-2085 - Improve validation of MDB activ...

2018-10-11 Thread rpelisse
Github user rpelisse commented on the issue: https://github.com/apache/activemq-artemis/pull/2312 @jbertram thanks! ---

[GitHub] activemq-artemis issue #2312: ARTEMIS-2085 - Improve validation of MDB activ...

2018-10-11 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2312 @rpelisse, to restart the Travis CI build you'll need to do something like `git commit --amend` and then `git push -f `. ---

[GitHub] activemq-artemis issue #2312: ARTEMIS-2085 - Improve validation of MDB activ...

2018-10-11 Thread rpelisse
Github user rpelisse commented on the issue: https://github.com/apache/activemq-artemis/pull/2312 retest this please ---

[GitHub] activemq-artemis pull request #2353: Log STOMP transaction starts with debug...

2018-10-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2353 ---

[GitHub] activemq-artemis pull request #2353: Log STOMP transaction starts with debug...

2018-10-11 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2353#discussion_r224540535 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java

[GitHub] activemq-artemis issue #2312: ARTEMIS-2085 - Improve validation of MDB activ...

2018-10-11 Thread rpelisse
Github user rpelisse commented on the issue: https://github.com/apache/activemq-artemis/pull/2312 @michaelandrepearce ok all fix now, let me know if you want me to change anything else! ---

[GitHub] activemq-artemis pull request #2365: ARTEMIS-2121 reload logging config at r...

2018-10-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2365 ---

[GitHub] activemq-artemis issue #2367: NO-JIRA - fixing up some broken tests

2018-10-11 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2367 There was a JIRA recently about changing the IDs, ARTEMIS-1018, if it caused these failures the fixup commit should have gone against that too rather than being a NO-JIRA. ---

[GitHub] activemq-artemis pull request #2312: ARTEMIS-2085 - Improve validation of MD...

2018-10-11 Thread rpelisse
Github user rpelisse commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2312#discussion_r224460300 --- Diff: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationValidationUtils.java --- @@ -0,0 +1,80 @@

[GitHub] activemq-artemis pull request #2312: ARTEMIS-2085 - Improve validation of MD...

2018-10-11 Thread rpelisse
Github user rpelisse commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2312#discussion_r224460169 --- Diff: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationValidationUtils.java --- @@ -0,0 +1,80 @@

[GitHub] activemq-artemis pull request #2312: ARTEMIS-2085 - Improve validation of MD...

2018-10-11 Thread rpelisse
Github user rpelisse commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2312#discussion_r224459911 --- Diff: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java --- @@ -603,7 +596,11 @@ public void

[GitHub] activemq pull request #307: [AMQ-7063] Be able to configure ActiveMQ http tr...

2018-10-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq/pull/307 ---

[GitHub] activemq-artemis pull request #2367: NO-JIRA - fixing up some broken tests

2018-10-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2367 ---

[GitHub] activemq-artemis pull request #2367: NO-JIRA - fixing up some broken tests

2018-10-11 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/2367 NO-JIRA - fixing up some broken tests updated tests that rely on logging id's You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq pull request #307: [AMQ-7063] Be able to configure ActiveMQ http tr...

2018-10-11 Thread jbonofre
GitHub user jbonofre opened a pull request: https://github.com/apache/activemq/pull/307 [AMQ-7063] Be able to configure ActiveMQ http transport connector by providing a jetty.xml You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2366: NO-JIRA cli test fixes

2018-10-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2366 ---

[GitHub] activemq-artemis pull request #2353: Log STOMP transaction starts with debug...

2018-10-11 Thread scop
Github user scop commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2353#discussion_r224324385 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java --- @@ -1711,7 +1711,7 @@ void

[GitHub] activemq-artemis pull request #2366: NO-JIRA cli test fixes

2018-10-11 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2366 NO-JIRA cli test fixes fix pom to not use hard coded version close cf You can merge this pull request into a Git repository by running: $ git pull