Github user tadayosi commented on the issue:
https://github.com/apache/activemq-artemis/pull/2410
@feuillemorte Sorry for the late response. Looks good to me!
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2385
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2418
Pushed update and build with above mentioned changes,
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2418
So i looked at this some more to see what i can do, i simply can't work
around the fact the OpenWireMessage will always return an int, as such it will
always set sequence, so
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2418
> So openwire always returns a value on asking groupseq. It never gives an
ability to determine if it was set by client or not.
It does seem to return a value if you ask for one,
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2418
I can add tests that would show the other breaks i found. That a sticky
plaster null check solution wouldnt fix.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2418
I would much rather we fix this proper of your adament for a sticky plaster
then fine. But i see doing that being problematic longer run as we just keep
hiding underlying
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2418
Re:
Oh, right. Yes, according to the changelog adding it, it deliberately
wasn't implemented in the AMQPMessage, which makes sense because per my earlier
comment using
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2418
So openwire always returns a value on asking groupseq. It never gives an
ability to determine if it was set by client or not.
---
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2418
> Re seq not set, its an int field so its tech always set if you request
it, just should default 0 if not set.
JMSXGroupSeq is set explicitly by the application. If it isn't set
Github user jsmucr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2420
Okay. :)
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2420
@jsmucr maybe then an integration test to prove it, and also to make sure
if it does work. No one breaks it on you
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2413
Looks sensible to me. I normally leave you just to merge. Let me know if
youd rather someone else (me) to merge, ill do it later tonight if so
---
Github user jsmucr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2420
I think you mean something like this, right?
```JAVA_ARGS="$JAVA_ARGS -Dcom.sun.management.jmxremote"
JAVA_ARGS="$JAVA_ARGS -Dcom.sun.management.jmxremote.authenticate=false"
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2420
We fix the ports in my org this with using system properties on java
command line modifiying artemis.profile
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2385
Lgtm
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2385
@jostbg, yes I think they're essentially the same.
---
Github user jostbg commented on the issue:
https://github.com/apache/activemq-artemis/pull/2385
@jbertram is that a similar issue, but with AMQP?
https://issues.apache.org/jira/browse/ARTEMIS-2140
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2418
So the issue was sequence wasnt being transposed correctly also found other
jmsx ones werent in doing so. But just been under the cover. Thus what we fix
here.
Re the
I'd be happy to help with adding content, I remember a hackathon was
mentioned at one point.
Any way since it's now in git it would be great if people could contribute
so we can have a better website sooner rather than later.
Andy
On Tue, 6 Nov 2018 at 17:19, Martyn Taylor wrote:
> The site
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2420
Im not sure it does, i wrote this code and remember it not working well
when i did the same thing. Also you can set this as a separate system property
as per the docs
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2420
Have you confirmed that this change actually sets the RMI registry port as
expected?
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2287#discussion_r231511486
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java
---
@@ -299,36 +301,57 @@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2287#discussion_r231513243
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java
---
@@ -299,36 +301,57 @@
GitHub user jsmucr opened a pull request:
https://github.com/apache/activemq-artemis/pull/2420
Allow configuration of RMI registry port
Previously the port was always random. This caused problems with remote JMX
connections that needed to overcome firewalls. As of this patch, it's
Github user mnovak1 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2287
@TomasHofman Could you update the state of this PR, please?
---
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2418
I tried the tests and they worked, but it occurred to me that though
changes might be needed in general to fix whats currently stopping the tests
passing, just making them pass is likely
Github user asfgit closed the pull request at:
https://github.com/apache/activemq/pull/317
---
GitHub user franz1981 reopened a pull request:
https://github.com/apache/activemq-artemis/pull/2419
ARTEMIS-2100 address routing-type overridden on attaching AMQP sender
Added docs to explain the behaviour of management addresses on paging
You can merge this pull request into a Git
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2419
Wrong jira number :P
---
Github user franz1981 closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2419
---
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2419
ARTEMIS-2100 address routing-type overridden on attaching AMQP sender
Added docs to explain the behaviour of management addresses on paging
You can merge this pull request into a Git
32 matches
Mail list logo
