Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2473#discussion_r243139995
--- Diff:
artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
---
@@ -237,28 +236,39 @@ public void
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2467
@franz1981 I have pulled your netty change here for correctness. (Now with
everything async I had an issue and I almost came up with a similar fix..yours
was better and ready) :)
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2473#discussion_r243083234
--- Diff:
artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
---
@@ -237,28 +236,39 @@ public void
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2470
all lgtm, pun intended
If we could run the full testsuite just to be sure.
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2470#discussion_r243076837
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java
---
@@ -216,63 +216,63 @@ private static void
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2470#discussion_r243073035
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java
---
@@ -216,63 +216,63 @@ private
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2464#discussion_r243026861
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerReceiverContext.java
Github user jbertram closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2464
---
Github user BiNZGi closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2468
---
Github user BiNZGi commented on the issue:
https://github.com/apache/activemq-artemis/pull/2468
Thank you for the hint with JIRA. Today I have made some more tests and
recognized that there was a mismatch with the STOMP versions in my case. The
messages were in STOMP 1.1 but with CR
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2468
After looking at this a bit more closely I think this change is incorrect.
The optional carriage return (octet 13) was added in STOMP 1.2, but you have
changed
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2473
Yes there is a issue opened.
https://github.com/eclipse/jetty.project/issues/1425
that doesn't get fixed (PR didn't merged because the hacking into
URLClassLoader brings concerns)
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2467#discussion_r242970329
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/ExecutorNettyAdapter.java
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2473
Wasn't there a Jetty issue opened about this? If so, how was that resolved?
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2467#discussion_r242969136
--- Diff:
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2467#discussion_r242968808
--- Diff:
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2473
manually tested on Windows 7 64bit and Windows 10 64bit.
---
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2473
ARTEMIS-1058 Jars in web tmp dir locked on Windows
Because Sun's URLClassLoader never closes it's jar file handles
Jetty doesn't cleanup is temp web dir after Artemis broker shut
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2472
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2467#discussion_r242903263
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/ExecutorNettyAdapter.java
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2472
ARTEMIS-2208 Fix Unit Tests Pom
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-2208
Alternatively
GitHub user onlyMIT reopened a pull request:
https://github.com/apache/activemq-artemis/pull/2466
ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be
cleâ¦
### Test environment
1. Use 10,000 (9 thousand senders, 1 thousand consumers) MQTT connection on
Github user onlyMIT commented on the issue:
https://github.com/apache/activemq-artemis/pull/2466
@clebertsuconic Sorry, the pull request has been closed due to my
misoperation, and it has now been restored. thank you very much for your help
---
Github user onlyMIT closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2466
---
24 matches
Mail list logo
