[GitHub] activemq-artemis pull request #:

2018-12-23 Thread franz1981
Github user franz1981 commented on the pull request: https://github.com/apache/activemq-artemis/commit/dfa70680fed37d25aa3a6d0d6a0795e580495b6a#commitcomment-31769915 No need to synchronize it: `stores` is a concurrent hashmap and you can use the atomic `computeIfAbsent` that use a

[GitHub] activemq-artemis pull request #2478: ARTEMIS-2210 PagingStore creation is no...

2018-12-23 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2478 ARTEMIS-2210 PagingStore creation is not properly synchronized In PagingManagerImpl#getPageStore() the operations on the map 'stores' are not synchronzed and it's possible that more

[GitHub] activemq-artemis issue #2444: ARTEMIS-2186 Large message incomplete when ser...

2018-12-23 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2444 @jbertram my concerns have been addressed ---