[GitHub] activemq-artemis issue #2482: ARTEMIS-2214 Cache durable in PagedRe...

2018-12-27 Thread qihongxu
Github user qihongxu commented on the issue: https://github.com/apache/activemq-artemis/pull/2482 @michaelandrepearce Thanks for the review. Now I have changed the code at your suggestion. ---

[GitHub] activemq-artemis pull request #2482: ARTEMIS-2214 Cache durable in ...

2018-12-27 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2482#discussion_r244150563 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java --- @@ -74,6 +74,10 @@

[GitHub] activemq-artemis pull request #2482: ARTEMIS-2214 Cache durable in ...

2018-12-27 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2482#discussion_r244150155 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java --- @@ -363,4 +371,20

[GitHub] activemq-artemis pull request #2482: ARTEMIS-2214 Cache durable in ...

2018-12-27 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2482#discussion_r244149886 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java --- @@ -74,6 +74,10 @@