[GitHub] activemq-artemis issue #2481: ARTEMIS-2213 don't expire critical component i...

2018-12-29 Thread wy96f
Github user wy96f commented on the issue: https://github.com/apache/activemq-artemis/pull/2481 @franz1981 thanks for your advice. We've enabled gc log and run the nano program. Any news will be reported:) ---

[GitHub] activemq-artemis issue #2482: ARTEMIS-2214 Cache durable in PagedRe...

2018-12-29 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2482 Just looking over this a bit more. As the page ref needs to be a small as possible. The whole point of paging is to remove it from memory to be able to scale. With

[GitHub] activemq-artemis issue #2484: ARTEMIS-2216 Use a specific executor for pageS...

2018-12-29 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2484 Comments on this are: We have shared executor and thread pools as a way to pool these its part artemis design so that these can be controlled, eg the number of threads

[GitHub] activemq-artemis issue #2482: ARTEMIS-2214 Cache durable in PagedRe...

2018-12-29 Thread qihongxu
Github user qihongxu commented on the issue: https://github.com/apache/activemq-artemis/pull/2482 > Nice catch!!! > If you care about checking perf of paging please try to profile the broker with https://github.com/jvm-profiling-tools/async-profiler using lock/cpu events too: it

[GitHub] activemq-artemis pull request #2485: ARTEMIS-2217 ‘MQTTSessionState’ in ...

2018-12-29 Thread onlyMIT
GitHub user onlyMIT opened a pull request: https://github.com/apache/activemq-artemis/pull/2485 ARTEMIS-2217 ‘MQTTSessionState’ in the ‘SESSIONS ConcurrentHashMap’ n… …ever be removed ‘MQTTSessionState’ in the ‘SESSIONS ConcurrentHashMap’ should be

[GitHub] activemq-artemis pull request #2483: ARTEMIS-2215 largemessage have been con...

2018-12-29 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2483#discussion_r244470771 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java --- @@ -461,8

[GitHub] activemq-artemis pull request #2483: ARTEMIS-2215 largemessage have been con...

2018-12-29 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2483#discussion_r244470859 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java --- @@

[GitHub] activemq-artemis pull request #2484: Use a specific executor for pageSyncTim...

2018-12-29 Thread qihongxu
GitHub user qihongxu opened a pull request: https://github.com/apache/activemq-artemis/pull/2484 Use a specific executor for pageSyncTimer Improve paging throughput by using a specific executor for pageSyncTimer Improving throughput on paging mode is one of our concerns

[GitHub] activemq-artemis pull request #2483: ARTEMIS-2215 largemessage have been con...

2018-12-29 Thread CNNJYB
GitHub user CNNJYB opened a pull request: https://github.com/apache/activemq-artemis/pull/2483 ARTEMIS-2215 largemessage have been consumed but not deleted During the backup and live synchronization, the client consumes the largemessage, then the live crash(the