[GitHub] clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456656799 @michaelandrepearce I'm pretty sure I will be able to merge this tomorrow. Testsuite had some unrelated failures. I just want to

[GitHub] asfgit closed pull request #2506: ARTEMIS-2230 Exception closing advisory consumers when supportAdvisory=false

asfgit closed pull request #2506: ARTEMIS-2230 Exception closing advisory consumers when supportAdvisory=false URL: https://github.com/apache/activemq-artemis/pull/2506 This is an automated message from the Apache Git

[GitHub] asfgit closed pull request #2473: ARTEMIS-1058 Jars in web tmp dir locked on Windows

asfgit closed pull request #2473: ARTEMIS-1058 Jars in web tmp dir locked on Windows URL: https://github.com/apache/activemq-artemis/pull/2473 This is an automated message from the Apache Git Service. To respond to the

[GitHub] clebertsuconic commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

clebertsuconic commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#issuecomment-456589194 I'm running the whole testsuite on this just in case. I think this PR is ok (thanks

[GitHub] clebertsuconic commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

clebertsuconic commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#issuecomment-456568393 I'm running tests on it.

[GitHub] jbertram commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

jbertram commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#issuecomment-456558383 @ldebello, I'll merge this soon or someone else with commit privileges can.

[GitHub] ldebello commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

ldebello commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#issuecomment-456554673 @jbertram one question do I need to do something else or you or someone from the team will take

[GitHub] clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456543088 It’s important to keep the testsuite clean. As we should release soon.

[GitHub] clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456542891 Let me run one final round of testsuite. If all good will merge it tomorrow.

Re: [VOTE] Apache ActiveMQ Artemis 2.6.4

+1 (non-binding) with comment. - Verified signature and checksum files. - Checked for LICENCE+NOTICE in archives. * - Ran the source build (only) from the tar.gz. - Seperately ran the AMQP integration tests. * The dates in the NOTICE files still reference 2018 and need updated. Robbie On Fri,

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456462793 @clebertsuconic hows this looking now, we good to merge???

Re: [VOTE] Apache ActiveMQ Artemis 2.6.4

+1 binding Well done guys and thanks Clebert!!! Il giorno lun 21 gen 2019 alle ore 17:25 michael.andre.pearce ha scritto: > Forgot to say, thanks as always to Clebert for running the release > > > Sent from my Samsung Galaxy smartphone. > Original message From:

[GitHub] ldebello commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

ldebello commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#issuecomment-456426737 > Couple of house-keeping items: > > * Squash all the commits. > * Don't put square

[GitHub] franz1981 commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

franz1981 commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456426021 @michaelandrepearce @clebertsuconic I'm going to run a test with it on the CI

[GitHub] jbertram commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

jbertram commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#issuecomment-456414742 Couple of house-keeping items: - Squash all the commits. - Don't put square brackets

[GitHub] jbertram removed a comment on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

jbertram removed a comment on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#issuecomment-456413907 Couple of house-keeping items: - Squash all the commits. - Don't put square

[GitHub] jbertram commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

jbertram commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#issuecomment-456413907 Couple of house-keeping items: - Squash all the commits. - Don't put square brackets

[GitHub] ldebello commented on a change in pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

ldebello commented on a change in pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#discussion_r249789341 ## File path:

[GitHub] michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456391920 @franz1981 looks like some alignment of latest changes with new tests

[GitHub] asfgit closed pull request #2513: ARTEMIS-2235 - remove credentials from browser log

asfgit closed pull request #2513: ARTEMIS-2235 - remove credentials from browser log URL: https://github.com/apache/activemq-artemis/pull/2513 This is an automated message from the Apache Git Service. To respond to the

[GitHub] andytaylor opened a new pull request #2513: ARTEMIS-2235 - remove credentials from browser log

andytaylor opened a new pull request #2513: ARTEMIS-2235 - remove credentials from browser log URL: https://github.com/apache/activemq-artemis/pull/2513 https://issues.apache.org/jira/browse/ARTEMIS-2235 This is an automated

[GitHub] asfgit merged pull request #2512: NOJIRA - just some minor build improvements

asfgit merged pull request #2512: NOJIRA - just some minor build improvements URL: https://github.com/apache/activemq-artemis/pull/2512 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] andytaylor opened a new pull request #2512: NOJIRA - just some minor build improvements

andytaylor opened a new pull request #2512: NOJIRA - just some minor build improvements URL: https://github.com/apache/activemq-artemis/pull/2512 This is an automated message from the Apache Git Service. To respond to the

[GitHub] franz1981 commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

franz1981 commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456323879 @michaelandrepearce I have added some comments to the PR you've sent bud :+1:

[GitHub] michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456323566 @franz1981 On the predicate logic, there is a small enhancement

[GitHub] michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456313267 Once/if you merge that, my concern on this PR is removed, and im +1 and