michaelandrepearce commented on a change in pull request #2432: [ARTEMIS-2176]
RA connection properties are not propagated to XARecov…
URL: https://github.com/apache/activemq-artemis/pull/2432#discussion_r250482029
##
File path:
michaelandrepearce commented on a change in pull request #2432: [ARTEMIS-2176]
RA connection properties are not propagated to XARecov…
URL: https://github.com/apache/activemq-artemis/pull/2432#discussion_r250482029
##
File path:
michaelandrepearce commented on a change in pull request #2432: [ARTEMIS-2176]
RA connection properties are not propagated to XARecov…
URL: https://github.com/apache/activemq-artemis/pull/2432#discussion_r250482029
##
File path:
franz1981 commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's
checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-457084424
@michaelandrepearce yep, it seems ok from the CI pov: there are just a
couple of
asfgit closed pull request #2305: NO-JIRA - Page.write() should throw exception
if file is closed
URL: https://github.com/apache/activemq-artemis/pull/2305
This is an automated message from the Apache Git Service.
To
Vote has passed with 7 +1 Votes
Binding:
+1 Clebert Suconic
+1 Timothy Bish
+1 Christopher Shannon
+1 Michael Andre Pearce
Non Binding:
+1 Howard Gao
+1 Francesco Nigro
+1 Robbie Gemmel
Thank you so much for everyone who contributed, and took time to
review the release candidate.
I will
>
> +1 (non-binding) with comment.
> * The dates in the NOTICE files still reference 2018 and need updated.
Thanks a lot! just updated it!
tabish121 commented on issue #17: AMQCPP-643: Add an option to time out
connection attempts when blocked in ensureConnectionInfoSent
URL: https://github.com/apache/activemq-cpp/pull/17#issuecomment-456951888
This is targeted at 3.9.x but would also need to go into master, can you
target
michaelandrepearce commented on issue #2274: ARTEMIS-2059 NettyWritable should
use UTF-8 exact length to encode strings
URL: https://github.com/apache/activemq-artemis/pull/2274#issuecomment-456951676
@franz1981 Can we close and reopen later once some more progress or
discussion is done.
michaelandrepearce commented on issue #1994: ARTEMIS-1787 Openwire message
should not contain internal property
URL: https://github.com/apache/activemq-artemis/pull/1994#issuecomment-456950879
As noted effort should go to native openwire message support #1793. Can we
close this.
michaelandrepearce commented on issue #1293: ARTEMIS-1194: SOCKS proxy support
URL: https://github.com/apache/activemq-artemis/pull/1293#issuecomment-456950321
@clebertsuconic whats occuring on this, we ok to merge? And simply mark
feature beta until some decent tests?
michaelandrepearce commented on issue #2199: ARTEMIS-1996
MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks
URL: https://github.com/apache/activemq-artemis/pull/2199#issuecomment-456949661
@morefuntang ping. I will close this in a couple days as no response for 3
michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized
CoreMessage's checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456947342
@franz1981 I happy to merge this if you are ready. Have been
michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized
CoreMessage's checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456947342
@franz1981 I happy to merge this if you are ready. Have been
michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized
CoreMessage's checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456947342
I happy to merge this if you are ready. Have been waiting for your ci
asfgit closed pull request #2515: ARTEMIS-1867 fix FQQNOpenWireTest
URL: https://github.com/apache/activemq-artemis/pull/2515
This is an automated message from the Apache Git Service.
To respond to the message, please log on
clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456913156
@michaelandrepearce duh.. thanks
This is an automated message
jbertram opened a new pull request #2515: ARTEMIS-1867 fix FQQNOpenWireTest
URL: https://github.com/apache/activemq-artemis/pull/2515
This is an automated message from the Apache Git Service.
To respond to the message,
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456881694
@clebertsuconic some of those variables are used but accesed by atomic
updaters. Have commented on your commit
asfgit closed pull request #2451: ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin
uses hard-coded RDN types
URL: https://github.com/apache/activemq-artemis/pull/2451
This is an automated message from the Apache Git Service.
To
clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456877360
I added one change on top of yours during merge... to remove unused
variables..
merged!
you are the man!
asfgit closed pull request #2490: ARTEMIS-196 Implement Consumer Priority
URL: https://github.com/apache/activemq-artemis/pull/2490
This is an automated message from the Apache Git Service.
To respond to the message, please
ldebello commented on issue #2510: [ARTEMIS-2156] Message Duplication when
using exclusive divert and clustering
URL: https://github.com/apache/activemq-artemis/pull/2510#issuecomment-456842951
@clebertsuconic sorry just one question to understand the workflow is common
to see the PR
asfgit closed pull request #2510: [ARTEMIS-2156] Message Duplication when using
exclusive divert and clustering
URL: https://github.com/apache/activemq-artemis/pull/2510
This is an automated message from the Apache Git
asfgit merged pull request #2514: ARTEMIS-2236 Address Latency Impact caused by
ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514
This is an automated message from the Apache Git Service.
To respond to
clebertsuconic commented on issue #2514: ARTEMIS-2236 Address Latency Impact
caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456837511
Oh shoot.. I don't know how I missed this.. I'm the one who merged it..
I wouldn't have merged it if
clebertsuconic commented on issue #2514: ARTEMIS-2236 Address Latency Impact
caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456821582
Give me some time to digest this, and I will bring it into 2.6.x as well.
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456771497
@franz1981 anything else do shout, it is appreciated to have the review :)
as you know we enjoy the
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456762201
Thanks to have verified, my laptop was giving weird results probably due to
low core numbers :(
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456761882
No discussions bud, just an observation: I have written this old tests some
time ago and given that I haven't
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456756498
@franz1981 im getting very similar results in distribution, not sure what
you are trying to discuss or
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456749562
@michaelandrepearce
PLease run this one:
```
public static void main(String[] args) throws Throwable
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456746664
> Franz is the man
He is indeed!!
michaelandrepearce commented on a change in pull request #2514: ARTEMIS-2236
Address Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250125913
##
File path:
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456742777
@franz1981 @gemmellr split the commits (there is now 2)
michaelandrepearce commented on a change in pull request #2514: ARTEMIS-2236
Address Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250125913
##
File path:
franz1981 commented on a change in pull request #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250126131
##
File path:
franz1981 commented on a change in pull request #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250124916
##
File path:
franz1981 commented on a change in pull request #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250124916
##
File path:
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-45673
@michaelandrepearce
> but @gemmellr sold me. Ill split the commits
I can say that's the right thing to
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456737591
@gemmellr @franz1981 i was in two minds as normally get asked to squash, but
@gemmellr sold me. Ill
gemmellr commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456734370
Franz is the man for this type of thing so I'll leave him to the review, but
I do think having a separate specific
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456727829
Yess and sorry for the "interrogation": given that's a core part you know
that I'm just concerned to understand
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456727468
Please go ahread ? does this mean youre happy? If so could you merge?
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456727468
Please go ahread ? does this mean youre happy?
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456727255
@michaelandrepearce
no no, bud don't worry: this was my ignorance :)
I've just look at the origianal
franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact
caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456727255
@michaelandrepearce
no no, bud don't worry: this was my ignorance :)
I've just look at the original
michaelandrepearce commented on a change in pull request #2514: ARTEMIS-2236
Address Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250108599
##
File path:
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725981
I can un-squash and make it a two stage commit if it helps? e.g. revert
commit, then remove sync
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725981
I can make it a two stage commit if it helps?
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725789
> I'm reverting but also removed the need for the sync blocks, and using
atomic updater to the threadTaskDelta
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725467
@franz1981 no indeed, and thats not what im doing.
Im reverting but also removed the need
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725467
@franz1981 no indeed, and thats not what im doing.
Im reverting but also removed the need
franz1981 commented on a change in pull request #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250105709
##
File path:
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725467
@franz1981 no indeed, and thats not what im doing.
Im reverting but also removed the need for the
franz1981 commented on a change in pull request #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250105709
##
File path:
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456724549
@franz1981 yup agree there are some improvements we could have done, but
have left them out.
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725073
@michaelandrepearce
Yep, but consider that providing a lock-free implementation *is* an
improvement that need
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456724549
@franz1981 yup agree there are some improvements we could have done, but
have left them out
As
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456724549
@franz1981 yup agree there are some improvements we could have done, but
have left them out
As
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456724549
@franz1981 yup agree there are some improvements we could have done, but
have left them out
As right
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456723336
Yep I see that there are a couple of things that could be addressed due to
this + a possible improvement: I will
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456722769
So all ive done, is revert that change of 1451 to put back semantics.
Streamlined the code
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456722769
So all ive done, is revert that change of 1451 to put back semantics.
Streamlined the code a tad,
franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact
caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456721762
Now that you've helped me to understand the issue I believe that's correct:
let me take a look to the PR
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456721762
Now that you've helped me to understand the issue I believe that's correct:
let me take a look to the current
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456720353
So the result i show provide the variance of 200,000 message as its split
per 10,000
Just total
franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact
caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719988
Ok, if that's the problem I agree with you that need to be addressed: is not
the behaviour of a
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719988
Ok, if that's the problem I agree with you that need to be addressed: is not
the behaviour of a thread-pool, that
franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact
caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719988
Ok, if that's the problem I agree with you that need to be addressed: is not
the behaviour of a
franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact
caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719095
@michaelandrepearce
Ok and the old thread-pool, assuming max thread count already reached, was
equally
franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact
caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719095
@michaelandrepearce
Ok and the old thread-pool, assuming max thread count already reached, was
equally
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719291
correct.
This is an automated message
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719095
@michaelandrepearce
Ok and the old thread-pool, assuming max thread count already reached, was
equally
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456718199
@franz1981 roughly correct
The original one before 1451, tried to re-use an idle thread if
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456718199
@franz1981 roughly correct
The original one before 1451, tried to re-use an idle thread if
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456718199
@franz1981 roughly correct
The original one before 1451, tried to re-use an idle thread if
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456718199
@franz1981 roughly correct
The original one before 1451, tried to re-use an idle thread if
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456717696
@michaelandrepearce
Ok, I need to understand this.
The new version distributes tasks across threads, but if
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456716626
@franz1981 This is what the old varient tried to avoid, was creating new
threads...
The
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456716626
@franz1981 This is what the old varient tried to avoid, was creating new
threads...
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456716247
@franz1981 its not down to sizing the thread pool.
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456715934
@michaelandrepearce
Please quote on my comments where "it's not" is referring to, to help me
understand
franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact
caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456714410
@michaelandrepearce I do understand but I believe that it could be dependent
by a wrong configuration,
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456715354
@franz1981 its not, the new behaviour is simply it creates a new thread
until the max pool size, this
franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact
caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456714410
@michaelandrepearce I do understand but I believe that it could be dependent
by a wrong configuration,
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456714410
@michaelandrepearce I do understand but I believe that it could be dependent
by a wrong configuration, given that
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456713968
@franz1981 we have been running investigations in a REAL environment going
back an forth between
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456713500
@michaelandrepearce I agree and that's why now we don't have to do the same
thing :)
Before saying that's a
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456712653
@franz1981 we dont even need, that the % change is quite significant.
Also note
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456712653
@franz1981 we dont even need, that the % change is quite significant.
Also note
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456712653
@franz1981 we dont even need, that the % change is quite significant. Also
note
franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact
caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456711246
Suggestion: i would use something more precise (with an higher spectrum of
latencies) if possible to make
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456709895
To show this, using a broker with persistance disabled (to remove external
disk perf factors),
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456708382
ARTEMIS-1451 removed synchronization in the class, by adding the overhead of
creating a new
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused
by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456711246
Suggestion: i would use something more precise (with an higher spectrum of
latencies) if possible to make things
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456708382
ARTEMIS-1451 removed synchronization in the class, by adding the overhead of
creating a new
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency
Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456710741
As this is performance regression, request this makes 2.7.0 and also
possible hot patched into 2.6.x
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456708382
1451 removed synchronization in the class, by adding the overhead of
creating a new thread until
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address
Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456709895
To show this, using a broker with persistance disabled (to remove external
disk perf factors),
1 - 100 of 104 matches
Mail list logo
