[GitHub] jbonofre merged pull request #344: Disable directory listing for the webconsole

2019-02-08 Thread GitBox
jbonofre merged pull request #344: Disable directory listing for the webconsole URL: https://github.com/apache/activemq/pull/344 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] clebertsuconic commented on a change in pull request #2545: ARTEMIS-2245 Cleaning up Docker images preparation, run and docs

2019-02-08 Thread GitBox
clebertsuconic commented on a change in pull request #2545: ARTEMIS-2245 Cleaning up Docker images preparation, run and docs URL: https://github.com/apache/activemq-artemis/pull/2545#discussion_r255229585 ## File path: artemis-docker/prepare-docker.sh ## @@ -29,7 +29,7 @@

[GitHub] michaelandrepearce edited a comment on issue #2547: Patched with live lock evaluation

2019-02-08 Thread GitBox
michaelandrepearce edited a comment on issue #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#issuecomment-461885590 Also could you look at: https://github.com/apache/activemq-artemis/pull/2287 Are these two solutions dealing

[GitHub] michaelandrepearce commented on issue #2547: Patched with live lock evaluation

2019-02-08 Thread GitBox
michaelandrepearce commented on issue #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#issuecomment-461885590 Also could you look at: https://github.com/apache/activemq-artemis/pull/2287 Are these to solutions dealing with same

[GitHub] michaelandrepearce commented on issue #2547: Patched with live lock evaluation

2019-02-08 Thread GitBox
michaelandrepearce commented on issue #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#issuecomment-461884720 Left some comments around using the common executor pools and better thread use. As like anything test case as well please

[GitHub] michaelandrepearce edited a comment on issue #2547: Patched with live lock evaluation

2019-02-08 Thread GitBox
michaelandrepearce edited a comment on issue #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#issuecomment-461884720 First of all thanks for looking to contribute. Left some comments around using the common executor pools and better

[GitHub] michaelandrepearce commented on a change in pull request #2547: Patched with live lock evaluation

2019-02-08 Thread GitBox
michaelandrepearce commented on a change in pull request #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#discussion_r255168820 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2547: Patched with live lock evaluation

2019-02-08 Thread GitBox
michaelandrepearce commented on a change in pull request #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#discussion_r255168020 ## File path:

[GitHub] coheigea opened a new pull request #344: Disable directory listing for the webconsole

2019-02-08 Thread GitBox
coheigea opened a new pull request #344: Disable directory listing for the webconsole URL: https://github.com/apache/activemq/pull/344 We should disable directory listing for the web console, as a good security practise.

[GitHub] michaelandrepearce commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

2019-02-08 Thread GitBox
michaelandrepearce commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#issuecomment-461819799 @clebertsuconic whilst im happy and would have merged. As you have raised a comment before i

[GitHub] michaelandrepearce edited a comment on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

2019-02-08 Thread GitBox
michaelandrepearce edited a comment on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#issuecomment-461819799 @clebertsuconic whilst im happy and would have merged. As you have raised a comment

[GitHub] emagiz opened a new pull request #2547: Patched with live lock evaluation

2019-02-08 Thread GitBox
emagiz opened a new pull request #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547 When using the shared store the live server can loose the lock on the journal but does not notice it. This can happen when a shared file system is being used

[GitHub] TomasHofman commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

2019-02-08 Thread GitBox
TomasHofman commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#issuecomment-461810090 @michaelandrepearce just checking out on this, are there any reservations on this? I'm not sure if

[GitHub] andytaylor opened a new pull request #2546: ARTEMIS-2249 - update cpp example to use correct client libs

2019-02-08 Thread GitBox
andytaylor opened a new pull request #2546: ARTEMIS-2249 - update cpp example to use correct client libs URL: https://github.com/apache/activemq-artemis/pull/2546 https://issues.apache.org/jira/browse/ARTEMIS-2249 This is an

[GitHub] franz1981 opened a new pull request #2545: ARTEMIS-2245 Cleaning up Docker images preparation, run and docs

2019-02-08 Thread GitBox
franz1981 opened a new pull request #2545: ARTEMIS-2245 Cleaning up Docker images preparation, run and docs URL: https://github.com/apache/activemq-artemis/pull/2545 I've included: - doc fixes on both the docker image preparation and guide - allowed users to run other artemis

[GitHub] ehsavoie closed pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-02-08 Thread GitBox
ehsavoie closed pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517 This is an automated message from the Apache

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-02-08 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r254982298 ## File path: