Re: [VOTE[ Release Apache NMS AMQP 1.8.0

2019-10-03 Thread michael . andre . pearce
Hi Tim Im assuming your -1 is for same couole of points Robbie noted. But just want to confirm. Best Mike Get Outlook for Android From: Timothy Bish Sent: Thursday 3 October, 20:44 Subject: Re: [VOTE[ Release Apache NMS AMQP 1.8.0 To: dev@activemq.apache.org -1

Re: [VOTE[ Release Apache NMS AMQP 1.8.0

2019-10-03 Thread michael . andre . pearce
Re version this was because there was a 1.7.x line of an attempt that didn't complete and never released. That older code base that was moved to a branch incase someone used it (was a discussion on that i believe back at the time). To avoid any issues or clashes in future it is natural

Re: Website build script [WAS Re: [activemq-website] 01/02: Adding upstream checkout on build.sh]

2019-10-03 Thread Clebert Suconic
I did not see the error again. I guess it was an effect of working late hours.. I messed something up. I was playing with --incremental on jekyll perhaps that's what caused it. Playing with a single branch would make it a lot easier. It bothers me to keep moving between branches as my IDE gets

Re: [VOTE[ Release Apache NMS AMQP 1.8.0

2019-10-03 Thread Timothy Bish
-1 (binding) On 10/3/19 3:30 PM, Krzysztof wrote: Hi Robbie, Ad 1: Could you elaborate a little about this? I've just downloaded all the bits to my home machine, unpacked it, and removed successfully. I've downloaded the binaries and can confirm that on a linux machine the src archive

Re: [VOTE[ Release Apache NMS AMQP 1.8.0

2019-10-03 Thread Krzysztof
Hi Robbie, Ad 1: Could you elaborate a little about this? I've just downloaded all the bits to my home machine, unpacked it, and removed successfully. Ad 2: I've submitted PR which adds missing license headers. Thank you so much for feedback. I hope that next spin will be more successful. On

Re: Website build script [WAS Re: [activemq-website] 01/02: Adding upstream checkout on build.sh]

2019-10-03 Thread Clebert Suconic
I copied the folder from the branch. Check out asf-siite Move it. Checkout the test branch Moved it back. On Thu, Oct 3, 2019 at 7:31 AM Robbie Gemmell wrote: > I dont see that happen when I run the build, and hadnt actually ever > seen the 'typechange' file status before. > > The

Re: [VOTE[ Release Apache NMS AMQP 1.8.0

2019-10-03 Thread Clebert Suconic
+1 On Thu, Oct 3, 2019 at 11:57 AM Robbie Gemmell wrote: > -1 (non-binding) > > - There is content in the archive permissioned in a way that you cant > access / delete it once you extract it, a little like the initial > 1.8.0 API RC archive had. > - There are some files that should have

Re: [VOTE[ Release Apache NMS AMQP 1.8.0

2019-10-03 Thread Robbie Gemmell
-1 (non-binding) - There is content in the archive permissioned in a way that you cant access / delete it once you extract it, a little like the initial 1.8.0 API RC archive had. - There are some files that should have headers which dont. Unfiltered RAT output summary below. Seperately from

Re: [VOTE[ Release Apache NMS AMQP 1.8.0

2019-10-03 Thread Duane Pauls
+1 non binding. Nice to see this, great work! Cheers, Duane On Thu, Oct 3, 2019 at 7:59 AM Krzysztof wrote: > +1 non binding > > Thanks, > Krzysztof > > On Thu, Oct 3, 2019 at 12:49 PM Michael Pearce > wrote: > > > Hi All, > > > > I have put together a spin for a Apache NMS AMQP release,

Re: [VOTE[ Release Apache NMS AMQP 1.8.0

2019-10-03 Thread Krzysztof
+1 non binding Thanks, Krzysztof On Thu, Oct 3, 2019 at 12:49 PM Michael Pearce wrote: > Hi All, > > I have put together a spin for a Apache NMS AMQP release, please > check it and vote accordingly. > > This release effectively will be the first release of a NMS AMQP client.. > > Also includes

Re: Website build script [WAS Re: [activemq-website] 01/02: Adding upstream checkout on build.sh]

2019-10-03 Thread Robbie Gemmell
I dont see that happen when I run the build, and hadnt actually ever seen the 'typechange' file status before. The content/schema/core/activemq-core.xsd is actually a symlink, and some googling suggests the 'typechange' status mainly happens when such link is replaced with an actual file. If I do

[VOTE[ Release Apache NMS AMQP 1.8.0

2019-10-03 Thread Michael Pearce
Hi All, I have put together a spin for a Apache NMS AMQP release, please check it and vote accordingly. This release effectively will be the first release of a NMS AMQP client.. Also includes some modernisation of the project that was needed to make the release, updating for latest visual