Re: [HEADS-UP] ActiveMQ JIRA clean-up

2020-12-01 Thread Jean-Baptiste Onofre
+1 I did a quick pass before 5.15.14 release, but definitely a more "concrete" plan makes sense. Thanks ! Regards JB > Le 1 déc. 2020 à 19:19, Matt Pavlovich a écrit : > > Hey all- > > In an effort to clean-up a number of tickets that are more likely stale and > fixed in recent releases,

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-01 Thread Jean-Baptiste Onofre
Hi Art, Thanks for the update ! Yeah, those tests are some of I would like to fix (they fail for quite long now, since at least 5.15.9). I think some tests should be removed because they don’t make sense anymore. I will take a look (I’m also improving the Karaf tests which are flaky). By the

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-01 Thread Arthur Naseef
So the ClassCastException happens in 5.15.13 and 5.15.10 when I run that test specifically. I suspect we have a case where the test class inheritance is causing confusion. If so, then the fix here is to bypass the base-class test method. Can someone look at the test method

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-01 Thread Arthur Naseef
Looks like I'm finding 2 problems with the InMemeoryJmsSchedulerTest: 1. The ClassCastException in one test, and 2. "Didn't receive the message" problem in the other. Digging into the ClassCastException, all the code appears to be unchanged for at least 6 months. Could this have been

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-01 Thread Arthur Naseef
So it looks like my build only had 2 test failures. The first we discussed already. The second is as follows: [INFO] Running org.apache.activemq.broker.scheduler.memory.InMemeoryJmsSchedulerTest [ERROR] Tests run: 8, Failures: 1, Errors: 1, Skipped: 0, Time elapsed: 41.993 s <<< FAILURE! - in

Re: [HEADS-UP] ActiveMQ JIRA clean-up

2020-12-01 Thread Matt Pavlovich
Yes, these are for the AMQ-* JIRAs > On Dec 1, 2020, at 12:36 PM, Justin Bertram wrote: > > Will this be for the AMQ project Jira [1] only or are you planning on > covering the Artemis project Jira [2] as well? Either way the effort is > certainly welcome. I just wanted to clarify as the

Re: [HEADS-UP] ActiveMQ JIRA clean-up

2020-12-01 Thread Justin Bertram
Will this be for the AMQ project Jira [1] only or are you planning on covering the Artemis project Jira [2] as well? Either way the effort is certainly welcome. I just wanted to clarify as the subject line was a little ambiguous to me. Justin [1] https://issues.apache.org/jira/browse/AMQ [2]

[HEADS-UP] ActiveMQ JIRA clean-up

2020-12-01 Thread Matt Pavlovich
Hey all- In an effort to clean-up a number of tickets that are more likely stale and fixed in recent releases, I’m planning on making a clean-up pass through JIRA. For tickets that pre-date 5.15.x (over 400 issues) 1. Review the ticket for relevance and likeliness to still be an issue. 2. If