[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework

Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 Thanks Tim, All good feedback. I've cleaned up the comments and white space. Added a new sample, and improved some of the 'toString' methods used in debugging/development. ---

[GitHub] activemq-nms-amqp pull request #1: AMQNET-576: Clean out old code base for N...

Github user RagnarPaulson closed the pull request at: https://github.com/apache/activemq-nms-amqp/pull/1 ---

[GitHub] activemq-nms-amqp issue #1: AMQNET-576: Clean out old code base for NMS AMQP...

Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/1 Per the last comment, and because the old repository is gone and a new one ready to replace it, I'm closing this pull request. ---

[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework

Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 Got it. I've just pushed up the latest version. It still passes all the tests using ActiveMQ as a broker, so I believe i got all the namespace changes correct. ---

[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework

Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 Thanks Tim, All good feedback. What is the process now? Should I commit my changes as a new commit, or quash it back into the original commit? Ragnar ---

[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework

Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 Thanks. That seemed to work better. Shows up as one commit now in the pull request. ---

[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework

Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 I've tried to follow the quash and rebase instructions outlined https://github.com/servo/servo/wiki/Beginner's-guide-to-rebasing-and-squashing But it's not clear to me

[GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework

Github user RagnarPaulson commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/2 Good catch. In my eagerness to compress several commits into one pull request I lost the .gitignore and inadvertently committed all the binaries/output. I've removed them all now. ---

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

GitHub user RagnarPaulson opened a pull request: https://github.com/apache/activemq-nms-amqp/pull/2 AMQNET-575: NMS AMQP Client Rework Add an NMS API implememntation that wraps the AMQPnetLite .NET API. Signed-off-by: Ragnar Paulson You can merge this pull request

[GitHub] activemq-nms-amqp pull request #1: AMQNET-576: Clean out old code base for N...

GitHub user RagnarPaulson opened a pull request: https://github.com/apache/activemq-nms-amqp/pull/1 AMQNET-576: Clean out old code base for NMS AMQP client provider. The first step to replacing the NMS AMQP client with a fully managed client based on AMQPNetLite is to remove