[GitHub] activemq-artemis issue #2287: ARTEMIS-2069 Backup doesn't activate after sha...

2018-12-11 Thread TomasHofman
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/2287 No, if `lockAcquisitionTimeout` is set to -1, it will wait 2 seconds, and then retry the lock. I don't see what you are referring to. There are two situations: * `tryLock

[GitHub] activemq-artemis pull request #2287: ARTEMIS-2069 Backup doesn't activate af...

2018-12-10 Thread TomasHofman
Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2287#discussion_r240294762 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java --- @@ -49,6 +49,8

[GitHub] activemq-artemis pull request #2287: ARTEMIS-2069 Backup doesn't activate af...

2018-12-10 Thread TomasHofman
Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2287#discussion_r240293147 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java --- @@ -49,6 +49,8

[GitHub] activemq-artemis issue #2287: ARTEMIS-2069 Backup doesn't activate after sha...

2018-11-20 Thread TomasHofman
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/2287 @jbertram @franz1981 we could really use this... ---

[GitHub] activemq-artemis issue #2287: ARTEMIS-2069 Backup doesn't activate after sha...

2018-11-12 Thread TomasHofman
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/2287 Everything looks OK now, so I will wait for merging and porting to 2.6.x, and then will update downstream PR for 2.6.3.jbossorg-x (will cherry-pick -x from 2.6.x port). ---

[GitHub] activemq-artemis issue #2287: ARTEMIS-2069 Backup doesn't activate after sha...

2018-11-12 Thread TomasHofman
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/2287 No automation? Thanks, will do. :) ---

[GitHub] activemq-artemis issue #2287: ARTEMIS-2069 Backup doesn't activate after sha...

2018-11-12 Thread TomasHofman
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/2287 Retest this please. ---

[GitHub] activemq-artemis pull request #2287: ARTEMIS-2069 Backup doesn't activate af...

2018-11-08 Thread TomasHofman
Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2287#discussion_r231878791 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java --- @@ -299,44 +303,52

[GitHub] activemq-artemis pull request #2287: ARTEMIS-2069 Backup doesn't activate af...

2018-11-08 Thread TomasHofman
Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2287#discussion_r231830652 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java --- @@ -299,36 +301,57

[GitHub] activemq-artemis pull request #2287: ARTEMIS-2069 Backup doesn't activate af...

2018-11-08 Thread TomasHofman
Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2287#discussion_r231822854 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java --- @@ -299,36 +301,57

[GitHub] activemq-artemis pull request #2287: ARTEMIS-2069 Backup doesn't activate af...

2018-09-03 Thread TomasHofman
GitHub user TomasHofman opened a pull request: https://github.com/apache/activemq-artemis/pull/2287 ARTEMIS-2069 Backup doesn't activate after shared store is reconnected https://issues.apache.org/jira/browse/ARTEMIS-2069 https://issues.jboss.org/browse/WFLY-10968 https

[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

2018-04-05 Thread TomasHofman
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/1987 @clebertsuconic I added my attempt at compatibility test. ---

[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

2018-04-03 Thread TomasHofman
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/1987 @clebertsuconic could you point me to where you keep similar tests? So far I have a deal with EAP QE that they would create it for EAP. ---

[GitHub] activemq-artemis pull request #1987: [ENTMQBR-1034] Connector parameters not...

2018-04-03 Thread TomasHofman
GitHub user TomasHofman opened a pull request: https://github.com/apache/activemq-artemis/pull/1987 [ENTMQBR-1034] Connector parameters not backward compatible https://issues.jboss.org/browse/ENTMQBR-1034 Fixing backward compatibility with HornetQ: * Translate transport

[GitHub] activemq-artemis pull request #1311: ARTEMIS-1187 Incompatible version when ...

2017-06-01 Thread TomasHofman
Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1311#discussion_r119632869 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -643,7

[GitHub] activemq-artemis pull request #1311: ARTEMIS-1187 Incompatible version when ...

2017-06-01 Thread TomasHofman
GitHub user TomasHofman opened a pull request: https://github.com/apache/activemq-artemis/pull/1311 ARTEMIS-1187 Incompatible version when recreating a session with olde… …r server https://issues.apache.org/jira/browse/ARTEMIS-1187 https://issues.jboss.org/browse

[GitHub] activemq-artemis pull request #1309: ARTEMIS-1186 Consumer.receive hangs if ...

2017-06-01 Thread TomasHofman
Github user TomasHofman closed the pull request at: https://github.com/apache/activemq-artemis/pull/1309 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] activemq-artemis pull request #1298: ARTEMIS-1187 Incompatible version when ...

2017-06-01 Thread TomasHofman
Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1298#discussion_r119549290 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -686,7

[GitHub] activemq-artemis pull request #1309: ARTEMIS-1186 Consumer.receive hangs if ...

2017-05-31 Thread TomasHofman
GitHub user TomasHofman opened a pull request: https://github.com/apache/activemq-artemis/pull/1309 ARTEMIS-1186 Consumer.receive hangs if http acceptor with non-zero ba… …tch-delay is configured https://issues.apache.org/jira/browse/ARTEMIS-1186 You can merge

[GitHub] activemq-artemis pull request #1298: ARTEMIS-1187 Incompatible version when ...

2017-05-31 Thread TomasHofman
Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1298#discussion_r119296506 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -686,7

[GitHub] activemq-artemis pull request #1298: ARTEMIS-1187 Incompatible version when ...

2017-05-29 Thread TomasHofman
GitHub user TomasHofman opened a pull request: https://github.com/apache/activemq-artemis/pull/1298 ARTEMIS-1187 Incompatible version when recreating a session with olde… …r server https://issues.apache.org/jira/browse/ARTEMIS-1187 https://issues.jboss.org/browse

[GitHub] activemq-artemis pull request #1297: ARTEMIS-1186 Consumer.receive hangs if ...

2017-05-29 Thread TomasHofman
GitHub user TomasHofman opened a pull request: https://github.com/apache/activemq-artemis/pull/1297 ARTEMIS-1186 Consumer.receive hangs if http acceptor with non-zero ba… …tch-delay is configured https://issues.apache.org/jira/browse/ARTEMIS-1186 https

[GitHub] activemq-artemis issue #849: ARTEMIS-805 old JMS clients failing on new brok...

2016-10-25 Thread TomasHofman
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/849 @clebertsuconic will this get into 1.4 branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] activemq-artemis pull request #849: ARTEMIS-805 old JMS clients failing on n...

2016-10-19 Thread TomasHofman
Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/849#discussion_r84056887 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -290,9

[GitHub] activemq-artemis pull request #849: ARTEMIS-805 old JMS clients failing on n...

2016-10-19 Thread TomasHofman
Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/849#discussion_r84055604 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -290,9

[GitHub] activemq-artemis pull request #791: ARTEMIS-747 multiple CDATA events on imp...

2016-09-23 Thread TomasHofman
Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/791#discussion_r80201908 --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataImporter.java --- @@ -444,33 +444,59 @@ private void