[GitHub] activemq-artemis pull request #2474: [ARTEMIS-1536]: Incorrect Journal files...

2018-12-20 Thread ehsavoie
Github user ehsavoie commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2474#discussion_r243354412 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java --- @@ -163,13

[GitHub] activemq-artemis pull request #2474: [ARTEMIS-1536]: Incorrect Journal files...

2018-12-20 Thread ehsavoie
Github user ehsavoie commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2474#discussion_r243331449 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java --- @@ -163,13

[GitHub] activemq-artemis pull request #2474: [ARTEMIS-1536]: Incorrect Journal files...

2018-12-20 Thread ehsavoie
GitHub user ehsavoie opened a pull request: https://github.com/apache/activemq-artemis/pull/2474 [ARTEMIS-1536]: Incorrect Journal filesize calculation where specified size is lest that the block size when using AIO. * If the specified file size is under the fs block size

[GitHub] activemq-artemis pull request #2416: [ARTEMIS-2163]: Classloading issue if a...

2018-11-14 Thread ehsavoie
Github user ehsavoie commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2416#discussion_r233576260 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java --- @@ -982,7 +982,13

[GitHub] activemq-artemis pull request #2416: [ARTEMIS-2163]: Classloading issue if a...

2018-11-14 Thread ehsavoie
Github user ehsavoie commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2416#discussion_r233531108 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java --- @@ -982,7 +982,13

[GitHub] activemq-artemis pull request #2416: [ARTEMIS-2163]: Classloading issue if a...

2018-11-05 Thread ehsavoie
GitHub user ehsavoie opened a pull request: https://github.com/apache/activemq-artemis/pull/2416 [ARTEMIS-2163]: Classloading issue if artemis-commons is not in the same classloader as artemis-client-* or artemis-server. * Setting TCCL to be able to load classes via

[GitHub] activemq-artemis pull request #1489: Chagning the way to interact with JGrou...

2017-08-23 Thread ehsavoie
GitHub user ehsavoie opened a pull request: https://github.com/apache/activemq-artemis/pull/1489 Chagning the way to interact with JGroups in the ResourceAdapter Obtaining a BroadCastEndpointFactory instead of a JChannel to connect to JGroups to avoid issue and leak with JChannel