Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2478
@franz1981 Title changed. Thanks mate!
---
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2478#discussion_r243866712
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingManagerImpl.java
---
@@ -335,19 +335,25 @@ public
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2478
@franz1981 I've update the branch, can you take a look? thx.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2478
@franz1981 ok, make sense. I'll change it. thx.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2478
@franz1981 Isn't that equivalent to a synchronize block? If so I think the
sysnchronized block is simpler, do you think?
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2478
The fix is so obvious that I decide not to provide a test. :)
---
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2478
ARTEMIS-2210 PagingStore creation is not properly synchronized
In PagingManagerImpl#getPageStore() the operations on the map 'stores'
are not synchronzed and it's possible that more
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2473#discussion_r243139995
--- Diff:
artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
---
@@ -237,28 +236,39 @@ public void start
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2473
Yes there is a issue opened.
https://github.com/eclipse/jetty.project/issues/1425
that doesn't get fixed (PR didn't merged because the hacking into
URLClassLoader brings concerns
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2473
manually tested on Windows 7 64bit and Windows 10 64bit.
---
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2473
ARTEMIS-1058 Jars in web tmp dir locked on Windows
Because Sun's URLClassLoader never closes it's jar file handles
Jetty doesn't cleanup is temp web dir after Artemis broker shut
Github user gaohoward closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2462
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2462
@clebertsuconic It's done.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2305
@jbertram Done. thx.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2462
ok, I'll make it separate commits. thx
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2462
@clebertsuconic I've update the PR including the regression fix.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2463
@clebertsuconic Can you take a look? thx.
---
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2463
ARTEMIS-2197 Page deleted before transaction finishes
Fixed regression caused by previous commit
b36dc37c152cabe3a0d9af178db043f842bfcdc0
You can merge this pull request into a Git
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2462
ARTEMIS-2197 Page deleted before transaction finishes
When a receiving transaction is committed in a paging situation,
if a page happens to be completed and it will be deleted
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2455
@clebertsuconic Can you review this? thx.
---
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2455
ARTEMIS-2197 Page deleted before transaction finishes
When a receiving transaction is committed in a paging situation,
if a page happens to be completed and it will be deleted
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2430
ARTEMIS-2174 Broker reconnect cause OOM with scale down
When a node tries to reconnects to another node in a scale down cluster,
the reconnect request gets denied by the other node
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2041
np at all.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2041
@michaelandrepearce Yes that's the idea.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2074
@clebertsuconic Can you merge it? thx
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2385
I think it's good.
---
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2386
ARTEMIS-2135 Test multiple core consumers receiving amqp messages
This test can verify an issue fixed by the commit:
48e0fc8f42346d96bc809593a150e05a586787ee (ARTEMIS-2135
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2383
@clebertsuconic I'll send a PR to 2.6.x but not cherry-pick from this.
Because on 2.6.x the fix is by a different commit not the one I mentioned here.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2383
ok will do.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2383
agreed I'll remove the NO-JIRA. thx.
---
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2383
NO-JIRA Adding a test for ARTEMIS-2096
This test can verify an issue fixed by the commit:
7a463f038ae324f2c5c908321b2ebf03b5a8e303 (ARTEMIS-2096)
The issue was reported
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2377#discussion_r226144345
--- Diff:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js ---
@@ -362,7 +362,7 @@ var ARTEMIS = (function(ARTEMIS
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2377
ARTEMIS-2133 Artemis tab not showing on IE browser
The web console on IE doesn't have 'Artemis' showed up because
it doesn't support javascripts => function.
You can me
Github user gaohoward closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2371
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2371
closing it for now, it needs more discussion.
---
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2371#discussion_r225383942
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
---
@@ -1789,6 +1790,11 @@ public
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2371#discussion_r225353248
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
---
@@ -1789,6 +1790,11 @@ public
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2371#discussion_r225353155
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
---
@@ -1789,6 +1790,11 @@ public
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2371#discussion_r225143852
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQAddressBlockedException.java
---
@@ -0,0 +1,24
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2371
ARTEMIS-2097 Pause and Block Producers
Added new methods to AddressControl and ServerControl to allow users
to block sending on addresses. Once blocked, any messages sending
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2305
https://issues.apache.org/jira/browse/ARTEMIS-2088
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2305
@clebertsuconic I've added more details to the commit comment.
---
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2305#discussion_r217584046
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
---
@@ -223,7 +224,7 @@ private int read
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2305#discussion_r217426008
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
---
@@ -223,7 +223,7 @@ private int read
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2305#discussion_r217242750
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
---
@@ -223,7 +223,7 @@ private int read
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2305
NO-JIRA - Page.write() should throw exception if file is closed
In Page.write(final PagedMessage message) if the page file is closed
it returns silently. The caller has no way
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2219
ARTEMIS-2013 Can't create durable subscriber to a composite topic
An OpenWire client can use a compound destination name of the form
"a,b,c..." and consume from, or
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2205
ah sorry about that. I'm closing it.
---
Github user gaohoward closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2205
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1950
I think it's ok.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2205
I think the ci build test failures relates to environment. All passes on my
local machine.
---
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2205
ARTEMIS-1995 Client fail over fails when live shut down too soon
In a live-backup scenario, if the live is restarted and shutdown too soon,
the client have a chance to fail
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2197
ARTEMIS-1995 Client fail over fails when live shut down too soon
In a live-backup scenario, if the live is restarted and shutdown too soon,
the client have a chance to fail
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2128
Closing this PR as it's a non issue.
---
Github user gaohoward closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2128
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2122
@mtaylor I've added some ssl test.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2122
@mtaylor worked with Andy and figured out ARTEMIS-1916 is not valid (PR
will be discarded). I've fixed the test and it should be ready for review now.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2128
@clebertsuconic I split it because Martyn suggested that this doesn't
belong to a test PR. (see Martyn's comment)
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2122
@mtaylor I've created another jira (ARTEMIS-1916) and the PR
https://github.com/apache/activemq-artemis/pull/2128
I also updated this PR. This PR should be merged after ARTEMIS
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2128
ARTEMIS-1916 Remove Jmx ArtemisRMIServerSocketFactory
The ArtemisRMIServerSocketFactory doesn't do anything special,
instead the existence of this impl class causes jmx client
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2122
@mtaylor ok, will do another jira. The code change is to remove the
RMIServerSocketFactory because it does nothing special and it causes jmx client
fail to connect (don't know why
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2122
ARTEMIS-1904 Jmx Management Security Tests
* Added tests for jmx security
* Removed ArtemisRMIServerSocketFactory as it does nothing special
(instead use default factory from
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2101
ARTEMIS-1853 Adding Netty OpenSSL provider test
Added an example to demonstrate how to configure and use openssl
Moved/Added netty-tcnative dependency to artemis-distribution
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2092
ARTEMIS-1853 Adding Netty OpenSSL provider test
Added some netty openssl tests
Fix a NPE issue
You can merge this pull request into a Git repository by running:
$ git pull
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2090#discussion_r188604772
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2090#discussion_r188604794
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2090
ARTEMIS-1868 Openwire doesn't add delivery count in client ack mode
If a client ack mode consumer receives a message and closes without
acking it, the redelivery of the message
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2074
ok. btw I ran it within intellij it passes.
---
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2074
ARTEMIS-1850 QueueControl.listDeliveringMessages returns empty result
With AMQP protocol when some messages are received in a transaction,
calling JMX
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2049#discussion_r184700517
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSDurableConsumerTest.java
---
@@ -221,4
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2049
NO-JIRA: Added a AMQP JMS LargeMessage test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward/activemq-artemis f_1461
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2041
@clebertsuconic removed the debug logs.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2041
@clebertsuconic done.
---
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2041#discussion_r184259404
--- Diff:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/brokerDiagram.js ---
@@ -455,16 +457,27 @@ var ARTEMIS = (function(ARTEMIS
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2041
ARTEMIS-1825 Live-backup topology not correctly displayed on console
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2013
@stanlyDoge you got to remove @Override annotations from
ActiveMQServerControlImpl also.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2020
@stanlyDoge I think that may be fixed somewhere else probably? can you
provide your test?
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1988
@stanlyDoge @clebertsuconic I think for the moment we can stay with the
current version of hawtio. I'll bring your fix in.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2004
+1. The failed tests seems not relevant. Maybe a forced re-run would solve
this problem?
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2013
@stanlyDoge I didn't see that the two methods (sendQueueInfo.. and
updateDuplicate...) in ActiveMQServerControl are used anywhere. Could simple
deleting them from the interface solve
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2023
@michaelandrepearce The code is fine I think. It'll be nice you add some
unittests (e.g. in QueueControlTest) to verify it works. Also I find that the
"Group" in method n
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2021
NO-JIRA: Fix test regression
QuorumFailOverTest.testQuorumVotingLiveNotDead fails
because the quorum vote takes longer time to finish than
the test expects to.
(The test
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2015
I think using mapped file will get better performance over the NIO channel
read.
It would be better to have a unit test with it. @clebertsuconic wdyt?
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1999
@clebertsuconic @stanlyDoge done.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1999
ok I'll take care of them.
---
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1999#discussion_r180614044
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
---
@@ -511,6 +511,45
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2005
ARTEMIS-1797 Auto-create-address flag shouldn't block temp destination
creation
When creating a temp destination and auto-create-address set to false, the
broker throws
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1999#discussion_r180281379
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java
---
@@ -105,12 +105,16
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1999#discussion_r180279022
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java
---
@@ -105,12 +105,16
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1999#discussion_r180155663
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java
---
@@ -105,12 +105,16
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2000
ARTEMIS-1791 Large message files are not removed after redistribution
across a cluster
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/1999
ARTEMIS-1790 Improve Topology Member Finding
When finding out if a connector belong to a target node it compares
the whole parameter map which is not necessary. Also
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1984#discussion_r178819137
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
---
@@ -127,9 +126,6
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1984#discussion_r178696366
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
---
@@ -127,9 +126,6
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/1984
ARTEMIS-1779 ClusterConnectionBridge may connect to other nodes than its
target
The cluster connection bridge has a TopologyListener and connects to a new
node
each time
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1960
@clebertsuconic sorry I forgot it.
---
Github user gaohoward closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1960
---
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1965#discussion_r176415286
--- Diff:
artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompSession.java
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1965#discussion_r176306425
--- Diff:
artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompSession.java
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1965
please do not merge. We need discussion.
---
1 - 100 of 519 matches
Mail list logo
