Github user onlyMIT commented on the issue:
https://github.com/apache/activemq-artemis/pull/2485
@jbertram OKï¼I will close this RPãThere is a small suggestion, can you
keep the "getSessionState" methodï¼because the RP #2466 has used this methodã
In the case o
Github user onlyMIT closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2485
---
Github user onlyMIT commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2491#discussion_r246247094
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
---
@@ -117,14
Github user onlyMIT commented on the issue:
https://github.com/apache/activemq-artemis/pull/2493
The test is correct.can close the jira and pull request
---
Github user onlyMIT closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2493
---
Github user onlyMIT commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2491#discussion_r246095670
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
---
@@ -117,14
Github user onlyMIT commented on the issue:
https://github.com/apache/activemq-artemis/pull/2491
@jbertram I think I found out why your solution passed the testï¼ your
test was constructed on a wrong test code. the solution your provided, after I
tested it with the revised test
GitHub user onlyMIT opened a pull request:
https://github.com/apache/activemq-artemis/pull/2493
ARTEMIS-2223 when a new consumer is created, no subscription is called.
In the 'MQTTTest.testCleanSession()' test method, when a new consumer is
created, no subscription
Github user onlyMIT commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2491#discussion_r245879352
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
---
@@ -117,14
Github user onlyMIT commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2491#discussion_r245878622
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
---
@@ -117,14
Github user onlyMIT commented on the issue:
https://github.com/apache/activemq-artemis/pull/2485
@jbertram Nice! Really need more specific test
---
GitHub user onlyMIT opened a pull request:
https://github.com/apache/activemq-artemis/pull/2485
ARTEMIS-2217 âMQTTSessionStateâ in the âSESSIONS ConcurrentHashMapâ
nâ¦
â¦ever be removed
âMQTTSessionStateâ in the âSESSIONS ConcurrentHashMapâ should
Github user onlyMIT commented on the issue:
https://github.com/apache/activemq-artemis/pull/2466
@michaelandrepearce @clebertsuconic Added automated testing. And added
locks for sub and unSub operations
---
GitHub user onlyMIT reopened a pull request:
https://github.com/apache/activemq-artemis/pull/2466
ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be
cleâ¦
### Test environment
1. Use 10,000 (9 thousand senders, 1 thousand consumers) MQTT connection
Github user onlyMIT commented on the issue:
https://github.com/apache/activemq-artemis/pull/2466
@clebertsuconic Sorry, the pull request has been closed due to my
misoperation, and it has now been restored. thank you very much for your help
---
Github user onlyMIT closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2466
---
Github user onlyMIT commented on the issue:
https://github.com/apache/activemq-artemis/pull/2466
@clebertsuconic this is my first pull request on GitHubãThank you for
your understanding, I will try to use JIRA to submit the code, if you find the
problem, I hope you correct me.
---
Github user onlyMIT commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2466#discussion_r242583621
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -113,32 +113,7 @@
import
Github user onlyMIT commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2466#discussion_r242582946
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSubscriptionManager.java
Github user onlyMIT commented on the issue:
https://github.com/apache/activemq-artemis/pull/2466
@michaelandrepearce JIRA has been created ï¼
https://issues.apache.org/jira/projects/ARTEMIS/issues/ARTEMIS-2206?filter=addedrecently
Regarding automated testing, in addition
GitHub user onlyMIT opened a pull request:
https://github.com/apache/activemq-artemis/pull/2466
NO-JIRA The MQTT consumer reconnection caused the queue to not be cleâ¦
### Test environment
1. Use 10,000 (9 thousand senders, 1 thousand consumers) MQTT connection on
one
21 matches
Mail list logo
