Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-02 Thread Arthur Naseef
Oh nice. I missed this earlier. Thanks! Art On Wed, Dec 2, 2020 at 2:09 AM Jean-Baptiste Onofre wrote: > FYI, I fixed the issues (very quick fix) the InMemory test. > > Regards > JB > > > Le 2 déc. 2020 à 05:54, Jean-Baptiste Onofre a écrit : > > > > Hi Art, > > > > Thanks for the update !

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-02 Thread Arthur Naseef
Makes sense. Glad to hear the tests are run even if we have a few that fail consistently. When I did a few official AMQ builds, I learned to use "mvn -fn" to run through the entire build, then go back and re-run the tests that failed. At that time, running the tests more than once usually got

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-02 Thread Jean-Baptiste Onofre
FYI, I fixed the issues (very quick fix) the InMemory test. Regards JB > Le 2 déc. 2020 à 05:54, Jean-Baptiste Onofre a écrit : > > Hi Art, > > Thanks for the update ! > > Yeah, those tests are some of I would like to fix (they fail for quite long > now, since at least 5.15.9). > > I think

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-01 Thread Jean-Baptiste Onofre
Hi Art, Thanks for the update ! Yeah, those tests are some of I would like to fix (they fail for quite long now, since at least 5.15.9). I think some tests should be removed because they don’t make sense anymore. I will take a look (I’m also improving the Karaf tests which are flaky). By the

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-01 Thread Arthur Naseef
So the ClassCastException happens in 5.15.13 and 5.15.10 when I run that test specifically. I suspect we have a case where the test class inheritance is causing confusion. If so, then the fix here is to bypass the base-class test method. Can someone look at the test method

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-01 Thread Arthur Naseef
Looks like I'm finding 2 problems with the InMemeoryJmsSchedulerTest: 1. The ClassCastException in one test, and 2. "Didn't receive the message" problem in the other. Digging into the ClassCastException, all the code appears to be unchanged for at least 6 months. Could this have been

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-01 Thread Arthur Naseef
So it looks like my build only had 2 test failures. The first we discussed already. The second is as follows: [INFO] Running org.apache.activemq.broker.scheduler.memory.InMemeoryJmsSchedulerTest [ERROR] Tests run: 8, Failures: 1, Errors: 1, Skipped: 0, Time elapsed: 41.993 s <<< FAILURE! - in

[CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-11-30 Thread Jean-Baptiste Onofre
Hi everyone, Due to an issue with the fix for AMQ-8045, I cancel this vote to prepare a new one. Sorry about that. And thanks Art to find this. A new vote will start today. Regards JB > Le 24 nov. 2020 à 08:00, Jean-Baptiste Onofre a écrit : > > Hi everyone, > > I submit Apache ActiveMQ