I raised https://github.com/apache/activemq-artemis/pull/3186 to fix
things to work forJDK8, move it to a profile to make it optional on
JDK8, and enable it in CI. Still on by default in JDK11+.
Robbie
On Tue, 16 Jun 2020 at 15:03, Robbie Gemmell wrote:
>
> The additional couple minutes
The additional couple minutes slowdown from forking only happens on JDK8, yes.
The comparable couple minutes overhead from running with ErrorProne at
all happens across the board though. Given the extent I don't
personally think it's justified for every single build when it's on in
CI anyway, it
On Tue, Jun 16, 2020 at 8:47 AM Emmanuel Hugonnet wrote:
>
> I would deactivate error-prone with JDK 8 and only 'run' it on CI via a
> proper activated profile.
+1
I would deactivate error-prone with JDK 8 and only 'run' it on CI via a proper
activated profile.
As far as I understand this is not an issue with JDK 11 so we should have it
on per default on Java > = 11.
Emmanuel
Le 16/06/2020 à 14:34, Robbie Gemmell a écrit :
> I have come to realise that
I have come to realise that the newer ErrorProne config for JDK8 added
as part of https://issues.apache.org/jira/browse/ARTEMIS-2109 doesn't
actually work presently, i.e it isn't running. I have prepared a
couple of alternative changes that do get it working again, but they
themselves have issues
