[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-21 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 Jenkins looking good. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-21 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @clebertsuconic @mtaylor turns out I compared a String address with SimpleString, which always return false. Fixed that and added a simple test. Jenkins for the moment seems down,

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @clebertsuconic sure I'll take care of it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @gaohoward actually, the example managmeent is broken after this. Can you look please? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @mtaylor I will let you merge this.. but this PR is +1 from me.. nice job @gaohoward --- If your project is set up for it, you can reply to this email and have your

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 There might be a problem with Jenkins machine, the failure relates to 'memory allocation'. Not related to my PR. @clebertsuconic I ran the whole test suite on my local machine, there

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 Please. While the whole testsuite ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 OK, I removed the garbage files and reverted AmqpSendReceiveTest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 guys please hold on this commit, I found some garbage files need to remove. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @clebertsuconic @mtaylor This is a resubmit of FQQN PR, with all tests fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as