Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
ok. strange. will check that. thanks for mertging @clebertsuconic ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
don't know.. perhaps you did on a wrong branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
@clebertsuconic yep. thx. thought I would have fixed it myself..
the steps I did:
- git rebase -i HEAD~1
- change commit message
- git push --force
what
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
Wrong JIRA: it should be artemis-1174 and not 1147...
although I could fix it using ./scripts/checkout-PR.sh and
./scripts/merge-branch.sh.. so don't worry about it..
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
in general.. it would be better to just send a link on Idea instead of
duplicating the steps...
it's minor though.. I'm not going to fight about it :)
---
If your
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
@clebertsuconic why? do you mean specifics like version numbers or IntelliJ
specifics in general?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
@bennetelli I will merge it as it's already done.. but I'm a bit concerned
to keep documenting idea specifics.. ;)
---
If your project is set up for it, you can reply to this
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
I won't merge it if it's referencing the wrong JIRA. However, it's easy to
change. Just rebase interactively, re-word the commit message, and push -f.
The PR will update
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
Argh.. So you need to reject it, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
You've transposed 4 and 7 in the JIRA reference of your commit message. It
should be ARTEMIS-1174.
---
If your project is set up for it, you can reply to this email and have your
reply
10 matches
Mail list logo
