[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 There are a few tasks that would be nice to be in a release as well. I would do a short cycle including not only this. --- If your project is set up for it, you can reply to

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 +1 merging, once current tag in flight is done, just quickly to confirm we agreed we'd immediately re-tag with the console in so we can get end user feedback asap. @mtaylor you

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 I will merge this then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 I've just managed to get round to review this. I've been through all the source files, both in this and the original project to ensure everything is properly licensed. The original

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 pushed gitignore and rat exclusion for the build time generated overlays dir ide's create. --- If your project is set up for it, you can reply to this email and have your

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 You get that if your ide generates overlay. If you just use maven , maven cleans up, I saw same thing with intellij. We can add that to the ignores and we should add it

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 looks good, altho I had to tweak the build by adding '**/overlays/**' to the rat plugin --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 @clebertsuconic added, also re-skinned slightly so colour/theme match new logo a little better. --- If your project is set up for it, you can reply to this email and have your

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 @michaelandrepearce small tweak, can you add a link to the console on the main index? When you go to localhost you see this list: - API - User Manual -

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 Rebased post 2.2.0 tagging, also updated logo with new logo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 @clebertsuconic i believe I've sorted the security, so if secure and admin role you can login. It be still good to catchup with yourself and @mtaylor on IRC later today

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 @clebertsuconic if we can sort authentication, yes. This is what I'd like to speak to you and @mtaylor on. --- If your project is set up for it, you can reply to this email

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 You think it would be good on the release ? How much work to get the authentication working ? Or ready to merge but not release. We can talk on

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 @clebertsuconic @mtaylor I think this is nearing ready for merge. I will want to quickly catch up with you both maybe IRC on monday?, as need to discuss something. --- If

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 On back of Dan's comment if we can further reduce the size of the war. Rather than spending the effort in a complex and hard to maintain overlay, i thought i would see

Re: [GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

As noted by the auto generated mail, I've gone through and updated LICENSE file for anything not ASL (All code is MIT or BSD 3-clause - so ASF friendly). Also to note none require any NOTICE update. Sent from my iPhone > On 8 Jul 2017, at 08:02, michaelandrepearce

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 now includes updated LICENSE file updated for the above licenses not under ASL, it seems none require any NOTICE update. --- If your project is set up for it, you can reply to

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 From here: http://www.apache.org/legal/resolved.html#category-a We just have to list the components and the license and point to the location of the dependency in

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 @clebertsuconic or anyone can you let me know or point me in the direction what I need to do re Artemis's license/notice files for each of the license types. To meet ASF

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 here is list of packaged code/content/jars etc, and their licenses commons-codec-1.10.jar,ASL commons-fileupload-1.3.2.jar,ASL commons-io-2.2.jar,ASL

Re: [GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

and that would be the same as any previous branch... 1.x still active in Artemis, we cherry-pick fixes all the time... and same with previous branches on activemq.. it's a common thing here.. nothing different. you rework the console, you bump the release.. and if users still need the older

Re: [GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

> Well, yes and no.Once "released", you kind of have to build off of what’s > there and continue to support that way of doing things. If what’s there > doesn’t make any sense and needs to be completely re-organized or something, > that could be difficult if we have to continue supporting

Re: [GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

I think having it for one version as a release preview is a good approach that way we can get feedback also earlier on what we may want to add in which priority. Nothing better than user feedback which we only get after release Sent from my iPhone > On 6 Jul 2017, at 18:06, Daniel Kulp

Re: [GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

> On Jul 6, 2017, at 1:00 PM, Michael André Pearce > wrote: > > My view on 2 is that currently there is no capability having anything is > better than none. > > Any extra features can be added over time by those willing to contribute. > > Indeed there are some

Re: [GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

My view on 2 is that currently there is no capability having anything is better than none. Any extra features can be added over time by those willing to contribute. Indeed there are some bits I'd like to add but having something is better than nothing and certainly can now start the ball

Re: [GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

> On Jul 6, 2017, at 10:15 AM, Clebert Suconic > wrote: > > It seems that this is almost ready.. if we fix logging it could be merged... > > > It would be awesome if we could have the next release with this > already... even if we delay another week. > > > @Dan:

Re: [GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

> Nothing stopping you from releasing now and then releasing again once it's > ready. Sure.. but if it's just 3 or 4 days before it's ready, I would wait.

Re: [GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

On 07/06/2017 10:15 AM, Clebert Suconic wrote: It seems that this is almost ready.. if we fix logging it could be merged... It would be awesome if we could have the next release with this already... even if we delay another week. Nothing stopping you from releasing now and then releasing again

Re: [GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

It seems that this is almost ready.. if we fix logging it could be merged... It would be awesome if we could have the next release with this already... even if we delay another week. @Dan: WDYT? On Thu, Jul 6, 2017 at 9:45 AM, michaelandrepearce wrote: > Github user

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 Update on 7) made it use the local user-guide available. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 @clebertsuconic i think I've address'ed now 1-9 on the list Dan gave. Only bit left is adding/updating artemis LICENSE/NOTICE. Whats the process on this. Is

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 7 - custom help, with iframe loading the artemis docs (note would be nicer if we had an alias on the web for https://activemq.apache.org/artemis/docs/LATEST so we don't have to

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 3) section overlaid with references to other products removed. 6) with the reduction of the war and removal of features, this seems to no longer be generated 2) about

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 As PR states is WIP , is just to give visibility to all --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 Oh don't merge yet! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 just one request here.. don't leave master on an intermediate state this week.. I want to release before end of this week / early next week as I sent the heads up earlier.

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 addressed: 3) simply removed the feature/tab (isn't required) 4) dashboard is now just a jvm default (no camel) 5) simply removed 9) war is now slimmed down to:

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 re mail thread bits, addressed: point 1) - url path changed from /hawtio/ to /console/ point 8) fuse properties renamed. --- If your project is set up for it, you can

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1385 @clebertsuconic see i make two commits, one for my work solely (aka setting up and also the activemq brand plugin) and then another for the artemis-plugin noting Andy T as