[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-02-07 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 We do the same as if message group which doesn’t increase the pos if it’s exclusive just like it doesn’t if exclusive. We can enhance this if needed. Ping me on IR

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-02-07 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 @michaelandrepearce I think the logic should have been updated on QueueImpl for the exclusive consumer... You should just had the pos always 0. or have a different log

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-02-07 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 @michaelandrepearce i don't have the chance to merge it yet :( Anyway it seems that there aren't any objections so I suppose it is ok 👍 ---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-02-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 @franz1981 seems no objections, you still ok to merge? ---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-02-02 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 @michaelandrepearce @gtully @mtaylor If everything is fine I will going to merge it, ok? ---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-02-02 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 @gtully you happy if this is merged? Just waiting on this before I continue with the other bits as mentioned ---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-02-01 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 @michaelandrepearce Hey Michael. I think this was a temp failure. There is an Artemis PR job running now that doesn't show the git clone problem. The CI is shared and there are a bunch

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 @gtully yes there is a use case for the client part here in our org, thus why. I'd rather do this fully, than partial. @mtaylor or anyone with access, can someone look

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-02-01 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 @michaelandrepearce to make the feature work is trivial in queueimpl; to make it dynamic is a lot of code. I would have been shooting for an address setting and pulling that value in qu

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-01-31 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 @gtully ping. ---