Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1849
@franz1981 @michaelandrepearce I think it's good and am going to merge it.
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1849
@michaelandrepearce Yep, it has passed the same tests as master with no
regressions, hence it can be merged :+1:
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1849
@franz1981 you noted you were going to merge this once you ran all openwire
suite.
Also you said "I'm fixing the last few bits and it is getting in the right
shape to be
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1849
@franz1981 can you rebase this please?
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1849
I have no further comments. I havenât had a chance to run test suites but
as long as you run them and they pass Iâm happy
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1849
I'm going to merge this provided that is not causing any regressions on
OpenWire tests/compatibility tests :+1:
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1849
@michaelandrepearce
> FYI gains were with non persistence
Yep, I need to specify it on the JIRA thanks!
I'm fixing the last few bits and it is getting in the right shape
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1849
FYI gains were with non persistence, still need to sort native support of
open wire format for persistent.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1849
Btw I ran a perf test using my POC physical server setup, I see similar
gains, so +1 from me (once comments are addressed)
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1849
I'm running the some sanity tests on it.
perf-wire now OpenWire is just 10/20% less than Core protocol for non
durable messages (depending on message size), it has a much better
10 matches
Mail list logo