Github user yersan commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
@jbertram Done, thanks!
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
Although this has been merged the PR won't be closed automatically
(something funny going on in the automation). @yersan, please close this PR
manually.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
So forget what I said before. I'll merge this PR and then send a different
one upstream to deal with this issue in a different way given the management
objects have changed so
Github user yersan commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
@jbertram Note that there is no JMSServerControlTest test on master branch,
but it exists on 1.x. This test can be used to cover this issue against
regression, how do you usually deal with
Github user yersan commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
Ok, I'm going to close this one and create a new one for master and for 1.x
(cherry-picked from master once it is merged)
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
Ideally there would be a new PR on master and then a cherry-pick of that
same commit onto 1.x (which would preclude this PR from staying open).
---
Github user yersan commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
@jbertram will it work for you if I create a new one PR on master branch
and let this one open for 1.x?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
If you don't want to do it let me know, and I'll do it. No worries.
In any case, I think this PR should be closed.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
Typically issues like this would be fixed on the 'master' branch first and
then back-ported to any other branches to avoid regressions. Although the
JMSServerManager is deprecated on
