Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
Ok, I'll be "the decider". Will check with franz to see how much it's
worth to him
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
@tabish121 no regressions on the testsuites.. I will let you decide about
merging this or not.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
@tabish121 @franz1981 fair enough.. lets run the whole testsuite then..
then we can merge this.
---
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
The change as it is seems acceptable as it does reduce unnecessary
allocations when ByteMessages types cross to OpenWire. I've reviewed the
changes as it relates to the OpenWire
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
I agree but given the short window until a new release i have preferred to
push this (that's quite stable and safe) and taking my time to improve the
other optimal way. That pr
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
@franz1981 sorry.. but I -1 on this.. you ok with closing this?
---
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
That would be the more ideal thing to do yes.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
for optimizing OpenWire.. I would prefer implementing OpenWireMessage
properly. There's a PR open for that already.
---
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
@franz1981 So I think that you could avoid subclassing the
ActiveMQBytesMessage if you built the properties yourself instead of calling
setObjectProperty in setAMQMsgObjectProperties in
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
@tabish121 I'm sorry to have "hacked" like this the Open Wire class. The
best solution would be to avoid at all any allocation of
`ActiveMQBytesMessage`, any idea?
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
@clebertsuconic I need to run all the CI tests on it to be safe :+1:
---
11 matches
Mail list logo
