[GitHub] activemq-artemis issue #2115: ARTEMIS-1858 Expiry messages are not transvers...

2018-05-31 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2115 @clebertsuconic Looks like all the comments have been addressed here. Also this approach solves a number of related issues around reliance on the AMQP To field for the address info.

[GitHub] activemq-artemis issue #2115: ARTEMIS-1858 Expiry messages are not transvers...

2018-05-30 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2115 full testsuite pass here as well ---

[GitHub] activemq-artemis issue #2115: ARTEMIS-1858 Expiry messages are not transvers...

2018-05-30 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2115 I can change it. ---

[GitHub] activemq-artemis issue #2115: ARTEMIS-1858 Expiry messages are not transvers...

2018-05-30 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2115 I got 100% on the testsuite for this change. I have seen a few unrelated failures here.. but they are just noise. ---

[GitHub] activemq-artemis issue #2115: ARTEMIS-1858 Expiry messages are not transvers...

2018-05-30 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2115 The build failed with something unrelated. I amended the commit hash to rebuild the test. ---

[GitHub] activemq-artemis issue #2115: ARTEMIS-1858 Expiry messages are not transvers...

2018-05-30 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2115 @gemmellr / @michaelandrepearce changes made ---