Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
thanks a lot.. merging
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
The build looks good now
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
The easiest way to rebuild is to.
Got commit âamend
Got push -f
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
I don't think it's related as the test it failed on doesn't have a plugin
registered. I tried to see if I could trigger it to re-run the build in travis
ci but i didn't see a way to do t
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
@clebertsuconic - is this ok to merge?
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
Looks good to me
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
I removed the re-throw and the expect for the JMSException so it will only
pass on InvalidClientIDException as that is the only type that should be thrown
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
@michaelandrepearce - good point, i fixed it to bubble up the
ActiveMQException and so it is handled properly by the client
---
