[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script

2018-07-25 Thread zachary1006
Github user zachary1006 commented on the issue: https://github.com/apache/activemq-artemis/pull/2190 Sorry about pushing to the wrong branch. Thanks for fixing it. ---

[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script

2018-07-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2190 The PR should been on master.. and we cherry-pick it into 2.6.x I used some git-fu to merge it into master. ---

[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script

2018-07-24 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2190 I just wanted to know the results of the test on windows as I don’t have a box now. I will merge this. This is probably 2.6.x as well and I will merge it.

[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script

2018-07-24 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2190 I was offering a second view that there is an issue requiring a change and noting the proposal worked for me, not suggesting you should just keep modifying it yourself. ---

[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script

2018-07-24 Thread zachary1006
Github user zachary1006 commented on the issue: https://github.com/apache/activemq-artemis/pull/2190 Thanks, gemmellr. I was also able to manually edit the file and get things working, but we package this software as part of a distribution to clients, and it's not realistic for us to

[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script

2018-07-24 Thread dwickern
Github user dwickern commented on the issue: https://github.com/apache/activemq-artemis/pull/2190 ```bat set ARTEMIS_INSTANCE_ETC="${artemis.instance.etc}" set JVM_ARGS=%JVM_ARGS% -Dartemis.instance.etc="%ARTEMIS_INSTANCE_ETC%" ``` Won't this _always_ result in the

[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script

2018-07-24 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2190 FWIW, I created a broker instance on Windows with spaces in the directory name, and the broker failed to start using the suggested run command. I then edited the artemis.cmd within the

[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script

2018-07-24 Thread zachary1006
Github user zachary1006 commented on the issue: https://github.com/apache/activemq-artemis/pull/2190 Thanks for having a look at this PR. I ran the tests; the results are attached. My problem was Windows-specific, though. We could not start Artemis on a Windows machine

[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script

2018-07-24 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2190 These double quotes were added to deal with directories with space.. they were working fine at the time... Can you run