Github user rpelisse commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
> I merged this on master and 2.6.x. @rpelisse, can you please close this?
Gladly!
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
I merged this on master and 2.6.x. @rpelisse, can you please close this?
---
Github user rpelisse commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
@jbertram thanks!
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
@rpelisse, to restart the Travis CI build you'll need to do something like
`git commit --amend` and then `git push -f `.
---
Github user rpelisse commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
retest this please
---
Github user rpelisse commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
@michaelandrepearce ok all fix now, let me know if you want me to change
anything else!
---
Github user rpelisse commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
@michaelandrepearce I've updated this branch with my Unit tests. I did a
bit of refactor also, I hope it's fine with you and let me know if you want me
to change something!
---
Github user rpelisse commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
@michaelandrepearce maybe it's me, but it feels a bit like an overkill to
add such a test into the integration test. I would rather move the validation
logic into an Utils class (with
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
@rpelisse theres a suite of tests i believe under
(org.apache.activemq.artemis.tests.integration.ra ) package in the integration
test module, this would probably where i would
Github user rpelisse commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
@jbertram logger methodize - let me know if you want me to change something
there.
---
Github user rpelisse commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
@michaelandrepearce there is no unit test in the artemis-ra, do you want me
to add a first unit to validate this behavior? (I'm fine doing so, I just want
to be sure it is what you
11 matches
Mail list logo
