[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-15 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 @michalxo, in your test is it the management context that's leaking or something else? ---

[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-15 Thread michalxo
Github user michalxo commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 I have managed to reproduced this issue on VM by simply adding extra hdd, formatting it, and making Artemis to use it for bindings, journal, (etc..). Started broker, waited for all

[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-05 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 @franz1981, thanks for the suggestion, but I don't think this is *that* kind of leak. I came up with a way to test it and updated the PR. ---

[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-05 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 You can take a weak reference of the ManagementContext instance you want to test the leak, force a GC + run finalizer (we have a method in the test suite for that) and then verify that

[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-05 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 I couldn't find a way to write a test for this so I tested manually using the `forceFailover()` management method on the `ActiveMQServerControl`. If anybody has any clever ideas I'd