[GitHub] activemq-artemis issue #2387: ARTEMIS-2142 Support JMSXGroupSeq -1to close/r...

2018-11-06 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2387 @gemmellr ok debugging through to see what it could be. ---

[GitHub] activemq-artemis issue #2387: ARTEMIS-2142 Support JMSXGroupSeq -1to close/r...

2018-11-06 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2387 The 3 tests that failed earlier (in multiple envs) pass with this reverted, so it does seem related beyond the original coincidence of changing the same bits. ---

[GitHub] activemq-artemis issue #2387: ARTEMIS-2142 Support JMSXGroupSeq -1to close/r...

2018-11-06 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2387 Gemmellr please re check if this is actually related to this change. These passed when manually run on the branch ---

[GitHub] activemq-artemis issue #2387: ARTEMIS-2142 Support JMSXGroupSeq -1to close/r...

2018-11-06 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2387 There are integration test failures occurring on master recently due to some issue or change with JMSXGroupSeq handling, looks to be for Openwire-->AMQP tests: >

[GitHub] activemq-artemis issue #2387: ARTEMIS-2142 Support JMSXGroupSeq -1to close/r...

2018-10-29 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2387 I assume there isnt...ill merge tomorrow and cherry pick also. ---

[GitHub] activemq-artemis issue #2387: ARTEMIS-2142 Support JMSXGroupSeq -1to close/r...

2018-10-28 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2387 @clebertsuconic any objection to have this small bit in HF branch? Is causing some issues not being able to close groups ---

[GitHub] activemq-artemis issue #2387: ARTEMIS-2142 Support JMSXGroupSeq -1to close/r...

2018-10-23 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2387 This is to provide feature parity with ActiveMQ 5.x, with being able to close a group using -1 group sequence. http://activemq.apache.org/message-groups.html ---