[GitHub] activemq-artemis issue #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuff...

2019-01-09 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2479 @michaelandrepearce @clebertsuconic I have added some unit tests quite strict, given that these classes are used almost everywhere :+1: ---

[GitHub] activemq-artemis issue #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuff...

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2479 @franz1981 this is out my league on this, im not so familiar with journal bits/logic, you ok with me leaving this for @clebertsuconic ? ---

[GitHub] activemq-artemis issue #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuff...

2018-12-24 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2479 I'm running the CI on it: I would like to provide some unit test, but I'm not sure it makes sense, considering that the original code were already tested end-to-end. ---