[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-10-28 Thread barreiro
Github user barreiro commented on the issue: https://github.com/apache/activemq-artemis/pull/548 Superseded by #872 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-10-27 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/548 @barreiro can you close this one please, #872 will replace this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-10-24 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/548 @barreiro I wil need a JIRA, can you raise one on Artemis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-10-24 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/548 @barreiro just a FYI: I'm working on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-10-18 Thread barreiro
Github user barreiro commented on the issue: https://github.com/apache/activemq-artemis/pull/548 Rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-08-15 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/548 This will need a JIRA and a squash of the commit here as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-08-15 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/548 The failures on Paging is because the system currently doubles the size of the buffer, because the address name is not encoded as part of every message, while it is encoded during jo

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-08-15 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/548 @barreiro sorry it took me this long to get into this.. but lets close this one soon. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-08-15 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/548 @barreiro did you think of using an executor from the ThreadPool? (ExecutorFactory.createExecutor()) from ActiveMQServerImpl? What about using the same executor for the bindi

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-08-09 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/548 @mtaylor there's a test failure I need to take care before can merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-08-09 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/548 @clebertsuconic Any update on this? Did you manage to complete the comparison you wanted to do? --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-06-21 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/548 @clebertsuconic NP just checking we haven't forgot about this. Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-06-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/548 @mtaylor I want to compare this against #590. Especially on a test that is being added. Franceso proposed a garbage free approach on the journal that makes sense.. and I w

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-06-20 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/548 @clebertsuconic I think we can start looking at this now that we have 1.3.0 out the door. Are you able review? Thanks. --- If your project is set up for it, you can reply to this email a

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-06-01 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/548 lets defer merging this until the release is done. quite a big change now at the last minute.. better to wait next release. --- If your project is set up for it, you can rep