Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
This is actually well put together now.. merging it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
The tests are all ok.
I will do one final review tomorrow, but it looks good to merge. nice job!
---
If your project is set up for it, you can reply to this email and have
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
I will run tests and merge this tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user johnament commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user bayern39 commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
@clebertsuconic I have done it !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bayern39 commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
@johnament OK,I have done it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user johnament commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
@clebertsuconic think we can add the version aware stuff to the hacking
guide? Would be useful for those not very familiar to know how to deal with it.
---
If your project is set up for
Github user bayern39 commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
@johnament @clebertsuconic Hi,I have fixed the mistake!Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
Change activemq.version.incrementingVersion.. add 128 there...
on activemq-version.properties.. add 128 to the compatibleVersionList
also...
When you are
Github user bayern39 commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
@clebertsuconic Hi Clebertï¼I know how to get client version,but i do not
know how to get supported versionï¼can you tell me more detailï¼Thanks
---
If your project is set up for it,
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
This is much better... now the only thing wrong is the versioning.
There's no need to add any fields. When the client connects to the server
it will set the versionID when
Github user bayern39 commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
@clebertsuconic Hi,Clebert,I have committed a new,I have done as you say,
add a check of version ID and don't store the sessionContexts,but the last you
sayed "rough the ProtocolManagers
Github user bayern39 commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
@johnament I have fixed the mistake!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
I don't think we can merge this...
this is introducing a new datatype through the protocol and it will break
compatibility with older clients in both directions. You would
Github user bayern39 commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
@johnament yeah,I have seen the output,but when I run the new single test
on my local machine,it is not wrong.I will run it more times.
---
If your project is set up for it, you can
Github user johnament commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
BTW, you may want to look at the jenkins output. May be a new test failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user johnament commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
@bayern39 sorry, you're right. I just realized your changes in
`failoverOrReconnect` is in the client side.
---
If your project is set up for it, you can reply to this email and have
Github user bayern39 commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
@johnament Thanks ,John,I will fix the mistake.The last one you have
sayed,I do't understand it?The client judge the message type and decide the
next step, it has been done.
---
If
Github user johnament commented on the issue:
https://github.com/apache/activemq-artemis/pull/672
It strikes me that the client needs to know about this message type as
well, potentially.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
19 matches
Mail list logo
