Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/718
Thanks for the hints @jbertram. Will squash it together and fix the
violations as well. Sorry.. didn't know that.
---
If your project is set up for it, you can reply to this email and
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/718
Also, you have 3 checkstyle violations:
[ERROR]
src/main/java/org/apache/activemq/artemis/integration/vertx/OutgoingVertxEventHandler.java:[21,8]
(imports) UnusedImports: Unused
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/718
Can you squash those commits together so there's not a commit making the
change and another commit undoing it? That's a bit messy.
Also, your commit messages should follow the
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/718
Here the open improvement ticket:
https://issues.apache.org/jira/browse/ARTEMIS-680
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user johnament commented on the issue:
https://github.com/apache/activemq-artemis/pull/718
Could you create a Jira and reference it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
