[GitHub] activemq-artemis pull request #2274: ARTEMIS-2059 NettyWritable should use U...

2018-08-30 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2274#discussion_r214073404 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/util/NettyWritable.java --- @@ -106,7

[GitHub] activemq-artemis pull request #2274: ARTEMIS-2059 NettyWritable should use U...

2018-08-30 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2274#discussion_r214067838 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/util/NettyWritable.java --- @@

[GitHub] activemq-artemis pull request #2274: ARTEMIS-2059 NettyWritable should use U...

2018-08-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2274#discussion_r213379239 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/util/NettyWritable.java --- @@

[GitHub] activemq-artemis pull request #2274: ARTEMIS-2059 NettyWritable should use U...

2018-08-28 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2274 ARTEMIS-2059 NettyWritable should use UTF-8 exact length to encode strings NettyWritable.put(String) tries to enlarge the buffer used to write a UTF-8 string until