Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2448
---
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2448#discussion_r239486511
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -386,14 +386,27 @@ public
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2448#discussion_r239482834
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -386,14 +386,27 @@ public
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2448#discussion_r238910671
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -386,14 +386,27 @@ public
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2448#discussion_r238785616
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -386,14 +386,27 @@ public
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2448#discussion_r238422596
--- Diff:
tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TemporaryDestinationTest.java
---
@@ -265,6 +266,126 @@ public
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2448#discussion_r238416943
--- Diff:
tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TemporaryDestinationTest.java
---
@@ -265,6 +266,126 @@ public
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2448#discussion_r238413260
--- Diff:
tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TemporaryDestinationTest.java
---
@@ -265,6 +266,126 @@
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2448
ARTEMIS-2189 allow deleting temp dest when session is closed
You can merge this pull request into a Git repository by running:
$ git pull
