[GitHub] activemq-artemis pull request #2470: Fixes for alerts from lgtm.com

2018-12-19 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2470#discussion_r243076837 --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java --- @@ -216,63 +216,63 @@ private static void

[GitHub] activemq-artemis pull request #2470: Fixes for alerts from lgtm.com

2018-12-19 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2470#discussion_r243073035 --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java --- @@ -216,63 +216,63 @@ private

[GitHub] activemq-artemis pull request #2470: Fixes for alerts from lgtm.com

2018-12-18 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2470 Fixes for alerts from lgtm.com After reviewing lgtm.com based on #2290 I decided to fix a handful of the warnings and errors they reported. You can merge this pull request into a Git