michaelandrepearce commented on a change in pull request #2519: ARTEMIS-2238
Fixing QueueQuery on every single send on topics
URL: https://github.com/apache/activemq-artemis/pull/2519#discussion_r250767135
##########
File path:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
##########
@@ -423,16 +423,18 @@ private void doSendx(ActiveMQDestination destination,
throw new InvalidDestinationException("Destination " +
address + " does not exist");
}
} else {
- ClientSession.QueueQuery queueQuery =
clientSession.queueQuery(address);
- if (queueQuery.isExists()) {
- connection.addKnownDestination(address);
- } else if (destination.isQueue() &&
query.isAutoCreateQueues()) {
- if (destination.isTemporary()) {
- session.createTemporaryQueue(destination,
RoutingType.ANYCAST, address, null, query);
- } else {
- session.createQueue(destination, RoutingType.ANYCAST,
address, null, true, true, query);
+ if (destination.isQueue()) {
Review comment:
should also be:
query.isAutoCreateQueues()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
