michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456881694
@clebertsuconic some of those variables are used but accesed by atomic
updaters. Have commented on your commit
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456462793
@clebertsuconic hows this looking now, we good to merge???
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455592219
@clebertsuconic ive found the pesky thing, in ServerSessionImpl where i had
added a new parameter to the createConsumer
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455507116
@clebertsuconic so as noted, the message groups ones is sorted, repeat needs
to occur only if groupconsumer exist.
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455479033
@clebertsuconic fully rebased (including over the FQQN for producers stuff)
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455451227
@clebertsuconic one master is fixed ill rebase and if i could ask if you
then could re run this?
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455397205
@clebertsuconic could you look at this
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455394066
@clebertsuconic the message group test ones are are genuine, should be fixed
up in last push.
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455391365
@clebertsuconic can you recheck this against master, i know things like
testDoubleDelete are failing currently on master
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454952955
@clebertsuconic sorted,
just added ability in consumers to repeat (new repeatable iterator), and
then if group, we
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454874083
Sorted locally just extracting repeatble iterator logic as franz is keen on
this
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454854944
@clebertsuconic ok so i know whats going on, another feature i have
implemented for 2.7.0 reset of message groups, the test
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454842100
Ill have a look
This is an automated message from the
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454585309
rebased
This is an automated message from the Apache Git
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454488334
@franz1981 good to go?
This is an automated message from
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454180317
@franz1981 added the tests i owed you. Sorry took some time, had the weekend
off.
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453245632
@franz1981 i know i still owe you those tests...
This is
17 matches
Mail list logo
