[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-21 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-466147272 Answered your queries franz, Ill look to merge on monday if no further comments.

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-19 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-465330174 Ive run what i can of the CI and integration tests Tbh i have never managed to run a full one. Its one of

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-19 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-465224306 @franz1981 if you're happy could you merge please?

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-15 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463959867 @franz1981 done, now using a single array (thats lazy initiated)

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-15 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463949198 @franz1981 and now because of the refactor and simpler methods we need to support i think i can easily implement the

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-14 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463867719 @franz1981 the needing to copy a IntObjectHashmap, still didnt fit right with me. As such have had a sit and

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-14 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463640868 @franz1981 Hopefully fixed the checkstyle, netty used 4 space tabs we use 3, lol, i feel like an episode of

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-13 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463423401 @franz1981 as noted i found Netty has an int primitive hashmap implementation using open addressing

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463095530 So yes i think if you find a way to elegantly achieve that without a performance impact i personally would be open to

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463093738 @billpoole-mi as i said, if/when this merges, you're more than welcome to contribute further enhancements you want.

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly load