[ 
https://issues.apache.org/jira/browse/AMQ-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved AMQ-5559.
---------------------------------
    Resolution: Fixed

Looks good to me, resolving. 

We could optimise out the empty filter array and only create it there are 
filters, but thats not a big deal given where/when the code is executing. 
Arguably we should also create new Source objects, but I dont actually see any 
obvious problem with reusing it currently given how else we use them right now, 
so I think we can leave that for another time too.

> AMQP: dont list filters which are not actually being applied in AMQP attach 
> responses 
> --------------------------------------------------------------------------------------
>
>                 Key: AMQ-5559
>                 URL: https://issues.apache.org/jira/browse/AMQ-5559
>             Project: ActiveMQ
>          Issue Type: Sub-task
>          Components: AMQP
>    Affects Versions: 5.10.0, 5.10.1, 5.11.0
>            Reporter: Robbie Gemmell
>             Fix For: 5.12.0
>
>
> The broker currently sends source filters in its attach response even if they 
> are not being applied. Only filters which are actually in effect should be 
> listed in responses to allow clients to validate the behaviour they will 
> actually receive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to