Re: PageCursorProviderImp::finishCleanup inneficiency

2019-12-17 Thread Clebert Suconic
+1 on st least a flag to contain large messages. This is because we delete large messages on ack however to be 100% sure we wouldn’t miss anything (say in case of a crash) a double check is made. Perhaps we could add a record to the beginning of the page with -1 (undefined) or N recorda as large

Re: PageCursorProviderImp::finishCleanup inneficiency

2019-12-17 Thread yw yw
This is a good improvement, I thought about it too. With 1, I didn't come up with good idea to implement it. With 2, it seems more like a simple and direct optimization on reading page :) nigro_franz 于2019年12月17日周二 上午3:13写道: > Hi folks, > > I'm running some benchmarks on paging and I've noticed

PageCursorProviderImp::finishCleanup inneficiency

2019-12-16 Thread nigro_franz
Hi folks, I'm running some benchmarks on paging and I've noticed that PageCursorProviderImpl::finishCleanup is performing Page::read on a cache miss vs softCache just to call Page::delete, that will do something relevant only on the large messages in the page. I believe this could be improved by: