+1
- Ran internal test suite
> On Mar 9, 2022, at 11:10 PM, Jean-Baptiste Onofré wrote:
>
> Hi guys,
>
> I submit ActiveMQ 5.17.0 release (take #2) to your vote. Compared to the
> first attempt, we fixed geronimo jar version and shading of
> activemq-client, activemq-pool, activemq-jms-pool a
+1
On Sat, Mar 12, 2022 at 1:43 AM W B D wrote:
> +1 (non-binding)
>
>
> On Wed, Mar 9, 2022 at 9:23 PM Jean-Baptiste Onofré
> wrote:
>
> > Hi guys,
> >
> > I submit ActiveMQ 5.17.0 release (take #2) to your vote. Compared to the
> > first attempt, we fixed geronimo jar version and shading of
>
+1 (non-binding)
On Wed, Mar 9, 2022 at 9:23 PM Jean-Baptiste Onofré wrote:
> Hi guys,
>
> I submit ActiveMQ 5.17.0 release (take #2) to your vote. Compared to the
> first attempt, we fixed geronimo jar version and shading of
> activemq-client, activemq-pool, activemq-jms-pool artifacts.
>
> Th
+1 (binding)
Regards
JB
On Thu, Mar 10, 2022 at 6:10 AM Jean-Baptiste Onofré
wrote:
> Hi guys,
>
> I submit ActiveMQ 5.17.0 release (take #2) to your vote. Compared to the
> first attempt, we fixed geronimo jar version and shading of
> activemq-client, activemq-pool, activemq-jms-pool artifacts
+1
* Validated signatures and checksums
* Verified license and notice files in archives
* Checked source for license headers using apache-rat
* Built from source and ran a sampling of the tests
* Spun of the broker from the binary archive and tested some with the
Web Console
On 3/10/22 00:10,
I have just made a similar change to the 5.x release generation bits
of the site so that the pages include a note of Java version:
https://activemq.apache.org/components/classic/download/
https://activemq.apache.org/activemq-5016004-release
https://github.com/apache/activemq-website/commit/b41be90
Yep to clarity around 'requires Java 11+'.
Justin made a change to the website to make it clear for each release
on the Artemis download pages, i.e:
https://activemq.apache.org/components/artemis/download/ and
https://activemq.apache.org/components/artemis/download/past_releases,
the same thing co
+1 (non-binding)
I checked things over as follows:
- Verified the signature and checksum files.
- Checked for LICENCE + NOTICE files present in the archives.
- Checked headers in the source archive with: mvn apache-rat:check
- Ran the source build and the AMQP tests on JDK 11.
- Ran the Qpid JMS 1
+1 (binding), Everything looks good, thanks for the quick turnaround on the
second vote.
Also, the vote email says "JDK 11+ support for both build and runtime" but
I wanted to clarify for anyone who doesn't know that JDK 11 isn't just
supported but is also a minimum requirement now to build and ru
-1
due to the issue we found with Chris. I'm preparing a PR.
I gonna send another email to cancel this vote and prepare a new one.
Regards
JB
On Wed, Mar 9, 2022 at 8:17 PM Christopher Shannon <
christopher.l.shan...@gmail.com> wrote:
> JB narrowed the issue down to * as part of
> the bundle pl
JB narrowed the issue down to * as part of
the bundle plugin inside of activemq-client, activemq-jms-pool,
activemq-pool poms and is working on a PR now to fix it
On Wed, Mar 9, 2022 at 12:56 PM Robbie Gemmell
wrote:
> I would have voted positively had Chris not already found the issues
> he did
I would have voted positively had Chris not already found the issues
he did, which indeed seem like they need fixed.
I checked things out as follows:
- Verified the signature + checksum files.
- Checked for LICENCE and NOTICE files present in the archives.
- Checked headers in the source archive w
activemq-jms-pool also appears to be shaded. I didn't notice any other jars
but those 2 but we should double check them all i guess
On Wed, Mar 9, 2022 at 10:57 AM Jean-Baptiste Onofré
wrote:
> Thanks for the update. Let me take a look to identify the change. I will
> then cancel the vote and fi
Thanks for the update. Let me take a look to identify the change. I will
then cancel the vote and fix Geronimo jar and ActiveMQ-pool artifact.
Regards
JB
Le mer. 9 mars 2022 à 16:46, Christopher Shannon <
christopher.l.shan...@gmail.com> a écrit :
> Unfortunately I have to change my vote to -1.
Unfortunately I have to change my vote to -1.
It looks like the activemq-pool jar is now shaded and pulling in a bunch of
other stuff. This caused my build to break as it pulled in the old
javax.annotation packages which broke due to:
https://issues.apache.org/jira/browse/AMQ-8530
So I think we n
+1 (non-binding)Tested with some internal projects.Thanks JB!regardsFrançois
Message d'origine De : Jean-Baptiste Onofré
Date : 07/03/2022 18:25 (GMT+01:00) À :
dev@activemq.apache.org Objet : [VOTE] Apache ActiveMQ 5.17.0 release Hi
guys,*Finally*, after several weeks waitin
+1
Le lun. 7 mars 2022 à 18:25, Jean-Baptiste Onofré a
écrit :
> Hi guys,
>
> *Finally*, after several weeks waiting, I'm pleased to submit Apache
> ActiveMQ 5.17.0 release to your vote.
>
> This release is an important milestone in ActiveMQ roadmap, including 200
> issues, especially:
> - suppo
+1, Everything looks good.
I went through all the test failures and there are no issues that require
cancelling the vote (just some problems with a couple tests themselves,
flaky tests, and one spec jar problem that is an optional jar that only
affects tests so that can be fixed in 5.17.1 or 5.18.
I would hold off cancelling the vote just yet.
I did some digging into some of the test failures and one was an issue with
the test itself (DurableFiveBrokerNetworkBridgeTest) after refactoring that
needs fixing so don't need to cancel for that :
https://github.com/apache/activemq/pull/794
I also
JB,
Looks like we will need to cancel the vote as there are some real test
failures on main branch in CI:
https://builds.apache.org/job/ActiveMQ/job/ActiveMQ/job/main/114/#showFailuresLink
Unfortunately the quick test profile got activated on main but not
backported to 5.17.x by mistake so the te
20 matches
Mail list logo
